From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 19 Aug 2016 21:17:59 +0200 (CEST) Received: from smtp.codeaurora.org ([198.145.29.96]:45494 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992215AbcHSTRxPTQzl (ORCPT ); Fri, 19 Aug 2016 21:17:53 +0200 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6CDF661CF2; Fri, 19 Aug 2016 19:17:51 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D27866178A; Fri, 19 Aug 2016 19:17:50 +0000 (UTC) Date: Fri, 19 Aug 2016 12:17:50 -0700 From: Stephen Boyd To: Geert Uytterhoeven Cc: Ralf Baechle , Atsushi Nemoto , Mark Brown , Wim Van Sebroeck , Guenter Roeck , linux-clk@vger.kernel.org, linux-mips@linux-mips.org, linux-spi@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 3/3] MIPS: TXx9: Convert to Common Clock Framework Message-ID: <20160819191750.GV361@codeaurora.org> References: <1471541667-30689-1-git-send-email-geert@linux-m68k.org> <1471541667-30689-4-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471541667-30689-4-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 54701 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sboyd@codeaurora.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/18, Geert Uytterhoeven wrote: > diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c > index ada92db92f87d91a..2fdbcf91b2cc472c 100644 > --- a/arch/mips/txx9/generic/setup.c > +++ b/arch/mips/txx9/generic/setup.c > @@ -560,8 +527,39 @@ void __init plat_time_init(void) > txx9_board_vec->time_init(); > } > > +static void txx9_clk_init(void) > +{ > + struct clk *clk; > + int error; > + > + clk = clk_register_fixed_rate(NULL, "gbus", NULL, 0, txx9_gbus_clock); Can we use the clk_hw_*() based variants instead please? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project