From: Ralf Baechle <ralf@linux-mips.org>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-mips@linux-mips.org, Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] mips/pci: Reduce stack frame usage
Date: Mon, 19 Sep 2016 16:20:53 +0200 [thread overview]
Message-ID: <20160919142053.GB14137@linux-mips.org> (raw)
In-Reply-To: <1473780107-4375-1-git-send-email-keith.busch@intel.com>
On Tue, Sep 13, 2016 at 09:21:47AM -0600, Keith Busch wrote:
> This patch removes creating a fake pci device in MIPS early config
> access and instead just uses the pci bus to get the same functionality.
> The struct pci_dev is too large to allocate on the stack, and was relying
> on compiler optimizations to remove its usage.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
>
> While I don't have any hardware to test this, the change should be
> exactly the same as before, taking the direct route to the config read
> instead of letting the compiler optimize this.
>
> This patch is preparing to add surprise removed device handling to the
> pci_read_config_*, which makes the compiler optimization that currently
> removes the excessive stack usage impossible.
Looks ok so I've applied it. Atsushi?
Ralf
prev parent reply other threads:[~2016-09-19 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 15:21 [PATCH] mips/pci: Reduce stack frame usage Keith Busch
2016-09-19 14:20 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919142053.GB14137@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=keith.busch@intel.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox