From: Antony Pavlov <antonynpavlov@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>,
Alban <albeu@free.fr>,
ralf@linux-mips.org, linux-mips <linux-mips@linux-mips.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board
Date: Tue, 4 Oct 2016 14:26:14 +0300 [thread overview]
Message-ID: <20161004142614.4983d133078b4908e43efa3a@gmail.com> (raw)
In-Reply-To: <154dc5c8-0d40-9cd7-5997-0ede70605510@baylibre.com>
On Tue, 4 Oct 2016 12:11:11 +0200
Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 10/04/2016 12:09 PM, Yegor Yefremov wrote:
> > Hi Neil,
> >
> > On Tue, Oct 4, 2016 at 11:40 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> >> On 10/04/2016 11:09 AM, Alban wrote:
> >>> On Mon, 3 Oct 2016 17:35:31 +0200
> >>> Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>>
> >>>> The HAPROXY Aloha pocket board is a Load Balancer demo board based on the
> >>>> Atheros AR9331 SoC with 64Mbytes DDR and 16Mbytes on-board SPI Flash.
> >>>>
> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>
> >>> Please use device tree instead of adding another board file.
> >>>
> >>> Alban
> >>>
> >>
> >> Hi Alban,
> >>
> >> I'm quite surprised since it seems no device tree support is available for ath79,
> >> I would really like to have device tree for this board, but this is only a copy/paste of
> >> the mach-ap121 with button/leds gpio differences.
> >>
> >> Could it be possible to merge it ? I would be happy to support this board once device tree
> >> support is landed on the mips tree !
> >
> > Take a look at these DTS files from the current Linux tree:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dpt_module.dts
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
> >
> > etc.
> >
> > Regards,
> > Yegor
> >
>
> My bad, the qca naming is really disturbing.
>
> I will push a dts instead.
Please note that currently some led's names in device tree files are wrong
(e.g. dragino2 device tree https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts .
My bad! I have just copied led's names from OpenWRT platform files).
Please see the 'LED Device Naming' chapter for correct led naming scheme:
http://lxr.free-electrons.com/source/Documentation/leds/leds-class.txt#L41
--
Best regards,
Antony Pavlov
prev parent reply other threads:[~2016-10-04 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 15:35 [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board Neil Armstrong
2016-10-04 9:09 ` Alban
2016-10-04 9:40 ` Neil Armstrong
2016-10-04 10:09 ` Yegor Yefremov
2016-10-04 10:11 ` Neil Armstrong
2016-10-04 10:14 ` Yegor Yefremov
2016-10-04 10:21 ` Neil Armstrong
2016-10-05 6:59 ` Yegor Yefremov
2016-10-04 11:26 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004142614.4983d133078b4908e43efa3a@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=albeu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=narmstrong@baylibre.com \
--cc=ralf@linux-mips.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox