From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 12 Oct 2016 18:55:00 +0200 (CEST) Received: from bh-25.webhostbox.net ([208.91.199.152]:50978 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992781AbcJLQyxRU3BZ (ORCPT ); Wed, 12 Oct 2016 18:54:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date; bh=HXnTFAAdQfiTDBT7mee5MfI6WMRglv9h5dxXUbHz4lE=; b=WY+0c5VQ0Kr2b+78IsIcnlcLUG lnuw2TsTC/9vjG9Gzo/A8g7Reh7MEvhoRnbSD/WCggEMQFcEcbGb3y9L6qZDXR6x3EnG7mtE6qbbA vQeH0cJe2IEa2rxv6jl396BsIVUPy3BePByU2LACtxDKgj6KFBdKodjvzaf/g3wBktZ3NVY9/WnMl +Qv+LNXQM5LXOODMEmekIYsKV4er2J9TvCEOxl+0nf6ilW/sNZjVZjSM5YjlWcVTA9Zup9wLnJkVG j2I2MdK1wdnqh6vMywn/aNor2EzCVe/BoLjvAqY4zpT/msecyfAFrwlFqiY6OCxk7/EoJA0z3jARq 7w9WOIRQ==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:60760 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.86_1) (envelope-from ) id 1buMni-003r6u-DP; Wed, 12 Oct 2016 16:54:42 +0000 Date: Wed, 12 Oct 2016 09:54:45 -0700 From: Guenter Roeck To: Yang Ling Cc: Wim Van Sebroeck , Keguang Zhang , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH v1.1 1/2] watchdog: loongson1: Add Loongson1 SoC watchdog driver Message-ID: <20161012165445.GB20472@roeck-us.net> References: <20161011141029.GA26146@ubuntu> <701c5b53-c2b5-88af-1ff7-549edf68d7ae@roeck-us.net> <20161012163744.GA53619@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161012163744.GA53619@ubuntu> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - linux-mips.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 55398 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: linux@roeck-us.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Oct 13, 2016 at 12:37:44AM +0800, Yang Ling wrote: > On Tue, Oct 11, 2016 at 07:54:03AM -0700, Guenter Roeck wrote: > > On 10/11/2016 07:10 AM, Yang Ling wrote: > > >Add watchdog timer specific driver for Loongson1 SoC. > > > > > >Signed-off-by: Yang Ling > > > > > >--- > > >V1.1: > > > Add a little debugging information. > > >--- > > > drivers/watchdog/Kconfig | 7 ++ > > > drivers/watchdog/Makefile | 1 + > > > drivers/watchdog/loongson1_wdt.c | 160 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 168 insertions(+) > > > create mode 100644 drivers/watchdog/loongson1_wdt.c > > > > > >diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > >index 50dbaa8..28c44f2 100644 > > >--- a/drivers/watchdog/Kconfig > > >+++ b/drivers/watchdog/Kconfig > > >@@ -1553,6 +1553,13 @@ config PIC32_DMT > > > To compile this driver as a loadable module, choose M here. > > > The module will be called pic32-dmt. > > > > > >+config LOONGSON1_WDT > > >+ tristate "Loongson1 SoC hardware watchdog" > > >+ depends on MACH_LOONGSON32 > > >+ select WATCHDOG_CORE > > >+ help > > >+ Hardware driver for the Loongson1 SoC Watchdog Timer. > > >+ > > > # PARISC Architecture > > > > > > # POWERPC Architecture > > >diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile > > >index cba0043..bd3b00e 100644 > > >--- a/drivers/watchdog/Makefile > > >+++ b/drivers/watchdog/Makefile > > >@@ -162,6 +162,7 @@ obj-$(CONFIG_IMGPDC_WDT) += imgpdc_wdt.o > > > obj-$(CONFIG_MT7621_WDT) += mt7621_wdt.o > > > obj-$(CONFIG_PIC32_WDT) += pic32-wdt.o > > > obj-$(CONFIG_PIC32_DMT) += pic32-dmt.o > > >+obj-$(CONFIG_LOONGSON1_WDT) += loongson1_wdt.o > > > > > > # PARISC Architecture > > > > > >diff --git a/drivers/watchdog/loongson1_wdt.c b/drivers/watchdog/loongson1_wdt.c > > >new file mode 100644 > > >index 0000000..77b11f9 > > >--- /dev/null > > >+++ b/drivers/watchdog/loongson1_wdt.c > > >@@ -0,0 +1,160 @@ > > >+/* > > >+ * Copyright (c) 2016 Yang Ling > > >+ * > > >+ * This program is free software; you can redistribute it and/or modify it > > >+ * under the terms of the GNU General Public License as published by the > > >+ * Free Software Foundation; either version 2 of the License, or (at your > > >+ * option) any later version. > > >+ */ > > >+ > > >+#include > > >+#include > > >+#include > > >+#include > > >+ > > >+#include While you are at it, please order include files alphabetically. Thanks, Guenter