From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: MIPS: IP22: Fix binutils due to binutils 2.25 uselessnes.
Date: Fri, 16 Dec 2016 03:52:06 +0100 [thread overview]
Message-ID: <20161216025206.GE15191@linux-mips.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1612160206450.6743@tp.orcam.me.uk>
On Fri, Dec 16, 2016 at 02:22:16AM +0000, Maciej W. Rozycki wrote:
> On Thu, 15 Dec 2016, linux-mips@linux-mips.org wrote:
>
> > Fix build with binutils 2.25 by open coding the offending
> >
> > dli $1, 0x9000000080000000
> >
> > as
> >
> > li $1, 0x9000
> > dsll $1, $1, 48
> >
> > which is ugly be the only thing that will build on all binutils vintages.
>
> What about bit #31? Shouldn't this be say:
>
> lui $1, 0x9000
> dsll $1, $1, 16
> ori $1, $1, 0x8000
> dsll $1, $1, 16
>
> ?
Argh, didn't spot the `8' in there. 64 bit constants are way too long :)
Thanks for reporting, will fix.
Ralf
prev parent reply other threads:[~2016-12-16 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S23993072AbcLOP7sNw5Hx/20161215155948Z+1597@eddie.linux-mips.org>
2016-12-16 2:22 ` MIPS: IP22: Fix binutils due to binutils 2.25 uselessnes Maciej W. Rozycki
2016-12-16 2:22 ` Maciej W. Rozycki
2016-12-16 2:52 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216025206.GE15191@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox