From: James Hogan <james.hogan@imgtec.com>
To: Joshua Kinard <kumba@gentoo.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Linux/MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: Replace printk calls in cpu-bugs64.c with pr_info/pr_cont
Date: Thu, 2 Feb 2017 10:48:50 +0000 [thread overview]
Message-ID: <20170202104850.GI13049@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <f0edc411-178c-7f18-9be6-9d40892c54b5@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
On Thu, Feb 02, 2017 at 05:41:48AM -0500, Joshua Kinard wrote:
> On 02/02/2017 05:00, James Hogan wrote:
> > Hi Joshua,
> >
> > On Thu, Feb 02, 2017 at 03:56:26AM -0500, Joshua Kinard wrote:
> >> From: Joshua Kinard <kumba@gentoo.org>
> >>
> >> In arch/mips/kernel/cpu-bugs64.c, replace initial printk's in three
> >> bug-checking functions with pr_info and replace several continuation
> >> printk's with pr_info/pr_cont calls to avoid kernel log output like
> >> this:
> >>
> >> [ 0.899065] Checking for the daddi bug...
> >> [ 0.899098] no.
> >>
> >> This makes the output appear correctly:
> >>
> >> [ 0.898643] Checking for the daddi bug... no.
> >>
> >> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> >
> > A variation of this patch is already applied, but without the change of
> > printk -> pr_info:
> >
> > https://patchwork.linux-mips.org/patch/14916/
> >
> > https://git.linux-mips.org/cgit/ralf/upstream-sfr.git/commit/?id=35e7f7885e1b1b272a73c0de3227fc9a3e95a7e3
>
> Oh, thanks for that. I keep forgetting to go look at the upstream git queue.
> I noticed the issue when trying to boot my Onyx2 back up and only checked the
> main tree to see if it was fixed.
>
> Shouldn't the printk's have a log level, though? I thought that was the
> motivation behind using the various pr_* calls.
Yes probably. I'd consider that a separate change to fixing the
continuations though (according to a quick git grep there are 422
printks without log levels remaining in mips-for-linux-next arch/mips).
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-02-02 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 8:56 [PATCH] MIPS: Replace printk calls in cpu-bugs64.c with pr_info/pr_cont Joshua Kinard
2017-02-02 10:00 ` James Hogan
2017-02-02 10:41 ` Joshua Kinard
2017-02-02 10:48 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202104850.GI13049@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox