From: Ralf Baechle <ralf@linux-mips.org>
To: Mathias Kresin <dev@kresin.me>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH v3] MIPS: PCI: add controllers before the specified head
Date: Mon, 27 Mar 2017 15:10:24 +0200 [thread overview]
Message-ID: <20170327131024.GB5734@linux-mips.org> (raw)
In-Reply-To: <1490547936-21871-1-git-send-email-dev@kresin.me>
On Sun, Mar 26, 2017 at 07:05:36PM +0200, Mathias Kresin wrote:
>
> With commit 23dac14d058f ("MIPS: PCI: Use struct list_head lists") new
> controllers are added after the specified head where they where added
> before the specified head previously.
>
> Use list_add_tail to restore the former order.
>
> This patches fixes the following PCI error on lantiq:
>
> pci 0000:01:00.0: BAR 0: error updating (0x1c000004 != 0x000000)
>
> Fixes: 23dac14d058f ("MIPS: PCI: Use struct list_head lists")
> Signed-off-by: Mathias Kresin <dev@kresin.me>
Thanks Mathias, will apply.
Had I replied earlier, I would have requested the change you did yourself
in v3. It seems to me the more logic solution and also closer to the
code before Paul's 23dac14d058f changed it.
I'm going to take care of Sergei's nit also, no need to resend.
Ralf
prev parent reply other threads:[~2017-03-27 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 17:05 [PATCH v3] MIPS: PCI: add controllers before the specified head Mathias Kresin
2017-03-27 9:21 ` Sergei Shtylyov
2017-03-27 13:10 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327131024.GB5734@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dev@kresin.me \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox