From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, trivial@kernel.org
Subject: Re: [PATCH] MIPS: Remove confusing else statement in __do_page_fault()
Date: Thu, 13 Apr 2017 00:48:30 +0200 [thread overview]
Message-ID: <20170412224830.GA7899@linux-mips.org> (raw)
In-Reply-To: <20170330212703.32066-1-paul.burton@imgtec.com>
On Thu, Mar 30, 2017 at 02:27:02PM -0700, Paul Burton wrote:
> Commit 41c594ab65fc ("[MIPS] MT: Improved multithreading support.")
> added an else case to an if statement in do_page_fault() (which has
> since gained 2 leading underscores) for some unclear reason. If the
> condition in the if statement evaluates true then we execute a goto &
> branch elsewhere anyway, so the else has no effect. Combined with an #if
> 0 block with misleading indentation introduced in the same commit it
> makes the code less clear than it could be.
>
> Remove the unnecessary else statement & de-indent the printk within
> the #if 0 block in order to make the code easier for humans to parse.
Yuck ...
Applied. Thanks!
Ralf
prev parent reply other threads:[~2017-04-12 22:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 21:27 [PATCH] MIPS: Remove confusing else statement in __do_page_fault() Paul Burton
2017-03-30 21:27 ` Paul Burton
2017-04-12 22:48 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412224830.GA7899@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox