From: Stephen Boyd <sboyd@codeaurora.org>
To: zhoubb <zhoubb@lemote.com>
Cc: "Ralf Baechle" <ralf@linux-mips.org>,
"James Hogan" <james.hogan@imgtec.com>,
"John Crispin" <john@phrozen.org>,
"Steven J . Hill" <Steven.Hill@imgtec.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Fuxin Zhang" <zhangfx@lemote.com>,
"Zhangjin Wu" <wuzhangjin@gmail.com>,
"Kelvin Cheung" <keguang.zhang@gmail.com>,
"Yang Ling" <gnaygnil@gmail.com>, 谢致邦 <Yeking@red54.com>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-mips@linux-mips.org, linux-clk@vger.kernel.org,
"HuaCai Chen" <chenhc@lemote.com>
Subject: Re: [PATCH v7 7/8] clk: Loongson: Add Loongson-1A clock support
Date: Tue, 20 Jun 2017 13:44:44 -0700 [thread overview]
Message-ID: <20170620204444.GT4493@codeaurora.org> (raw)
In-Reply-To: <CAMpQs4L1_VvWxk_mkbRgvVb3o23m+RdVosgzxFLMRX7fjKa+6w@mail.gmail.com>
On 06/20, zhoubb wrote:
> On Tue, Jun 20, 2017 at 7:34 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 06/16, Binbin Zhou wrote:
> >> +
> >> +static DEFINE_SPINLOCK(_lock);
> >
> > I know the other loongson1*.c files also call it "_lock", but
> > that's not a very good name for something that may show up in
> > lockdep debugging error messages. How about something a bit more
> > descriptive, loongson1x_clk_lock?
> >
> It's a good idea！
> Actually, the variable is not be used in this file.
> If I rename it in another new patch will be better.
> Do you think so ?
Ok sure.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-20 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 2:52 [PATCH v7 0/8] MIPS: Loongson: Add the Loongson-1A processor support Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 1/8] MIPS: Loongson: Merge PRID macro for Loongson-1A/1B/1C Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 2/8] MIPS: Loongson: Expand Loongson-1's register definition Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 3/8] MIPS: Loongson: Add basic Loongson-1A CPU support Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 4/8] MIPS: Loongson: Add Loongson-1A Kconfig options Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 5/8] MIPS: Loongson: Add platform devices for Loongson-1A Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 6/8] MIPS: Loongson: Add Loongson-1A board support Binbin Zhou
2017-06-16 2:52 ` [PATCH v7 7/8] clk: Loongson: Add Loongson-1A clock support Binbin Zhou
2017-06-19 23:34 ` Stephen Boyd
2017-06-20 4:51 ` zhoubb
2017-06-20 20:44 ` Stephen Boyd [this message]
2017-06-16 2:52 ` [PATCH v7 8/8] MIPS: Loongson: Add Loongson-1A default config file Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620204444.GT4493@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Steven.Hill@imgtec.com \
--cc=Yeking@red54.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=gnaygnil@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=john@phrozen.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mturquette@baylibre.com \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
--cc=zhoubb@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox