From: Ralf Baechle <ralf@linux-mips.org>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header
Date: Wed, 19 Jul 2017 00:05:13 +0200 [thread overview]
Message-ID: <20170718220513.GB22091@linux-mips.org> (raw)
In-Reply-To: <1500384346-10527-2-git-send-email-harvey.hunt@imgtec.com>
On Tue, Jul 18, 2017 at 02:25:46PM +0100, Harvey Hunt wrote:
> Fix a build error caused by not including <linux/bug.h>.
>
> The following compilation errors are caused by the missing header:
>
> arch/mips/ralink/mt7620.c: In function ‘mt7620_get_cpu_pll_rate’:
> arch/mips/ralink/mt7620.c:431:2: error: implicit declaration of function ‘WARN_ON’ [-Werror=implicit-function-declaration]
> WARN_ON(div >= ARRAY_SIZE(mt7620_clk_divider));
> ^
> arch/mips/ralink/mt7620.c: In function ‘mt7620_get_sys_rate’:
> arch/mips/ralink/mt7620.c:500:2: error: implicit declaration of function ‘WARN’ [-Werror=implicit-function-declaration]
> if (WARN(!div, "invalid divider for OCP ratio %u", ocp_ratio))
> ^
> arch/mips/ralink/mt7620.c: In function ‘mt7620_dram_init’:
> arch/mips/ralink/mt7620.c:619:3: error: implicit declaration of function ‘BUG’ [-Werror=implicit-function-declaration]
> BUG();
> ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:302: recipe for target 'arch/mips/ralink/mt7620.o' failed
>
> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: John Crispin <john@phrozen.org>
> Cc: linux-mips@linux-mips.org
> Cc: linux-kernel@vger.kernel.org
Same comment as for the previous patch - looks sensible, so applied. But
I'm wondering why I don't see this in test builds.
Ralf
next prev parent reply other threads:[~2017-07-18 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 13:25 [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt
2017-07-18 13:25 ` Harvey Hunt
2017-07-18 13:25 ` [PATCH 2/2] MIPS: ralink: mt7620: Add " Harvey Hunt
2017-07-18 13:25 ` Harvey Hunt
2017-07-18 22:05 ` Ralf Baechle [this message]
2017-07-18 22:01 ` [PATCH 1/2] MIPS: ralink: Fix build error due to " Ralf Baechle
2017-07-19 10:55 ` Harvey Hunt
2017-07-19 10:55 ` Harvey Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718220513.GB22091@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=harvey.hunt@imgtec.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox