From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 06 Sep 2017 13:14:46 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:33812 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23991438AbdIFLOiz2MEq (ORCPT ); Wed, 6 Sep 2017 13:14:38 +0200 Received: from h7.dl5rb.org.uk (localhost [127.0.0.1]) by h7.dl5rb.org.uk (8.15.2/8.14.8) with ESMTP id v86BEa5W005597; Wed, 6 Sep 2017 13:14:36 +0200 Received: (from ralf@localhost) by h7.dl5rb.org.uk (8.15.2/8.15.2/Submit) id v86BEZmv005596; Wed, 6 Sep 2017 13:14:35 +0200 Date: Wed, 6 Sep 2017 13:14:35 +0200 From: Ralf Baechle To: Rocco Folino Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antony Pavlov , Alban Bedel , John Crispin Subject: Re: [PATCH] MIPS: ath79: support devicetree selection Message-ID: <20170906111435.GA1856@linux-mips.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 59944 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote: > Allow to choose devicetrees from Kconfig. > > Signed-off-by: Rocco Folino > --- > arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++ > arch/mips/boot/dts/qca/Makefile | 10 +++++----- > 2 files changed, 49 insertions(+), 5 deletions(-) > > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig > index dfc60209dc63..b43d116187af 100644 > --- a/arch/mips/ath79/Kconfig > +++ b/arch/mips/ath79/Kconfig > @@ -1,5 +1,49 @@ > if ATH79 > > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection" > + > +config DTB_ATH_DPT_MODULE > + bool "DPTechnics DPT-Module" > + select SOC_933X There is no symbol SOC_933X. Did you mean SOC_AR933X? Anyway, your patch does more than the changelog ("Allow to choose devicetrees from Kconfig") says, so please either fix the changelog or split that into multiple patches with proper changelogs. Ralf