From: Christoph Hellwig <hch@lst.de>
To: Mark Greer <mgreer@animalcreek.com>
Cc: Huacai Chen <chenhc@lemote.com>, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Fuxin Zhang <zhangfx@lemote.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
James Hogan <james.hogan@imgtec.com>,
linux-mips@linux-mips.org,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, stable@vger.kernel.org,
"Michael S . Tsirkin" <mst@mellanox.co.il>,
Pawel Osciak <pawel@osciak.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Michael Chan <michael.chan@broadcom.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ivan Mikhaylov <ivan@ru.ibm.com>,
Tariq Toukan <tariqt@mellanox.com>,
Andy Gross <agross@codeaurora.org>,
Robert Baldyga <r.baldyga@hackerion.com>
Subject: Re: [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()
Date: Thu, 19 Oct 2017 17:09:21 +0200 [thread overview]
Message-ID: <20171019150921.GB24204@lst.de> (raw)
In-Reply-To: <20171018172336.GA29358@animalcreek.com>
On Wed, Oct 18, 2017 at 10:23:36AM -0700, Mark Greer wrote:
> > #define MPSC_RXR_ENTRIES 32
> > -#define MPSC_RXRE_SIZE dma_get_cache_alignment()
> > +#define MPSC_RXRE_SIZE dma_get_cache_alignment(dma_dev)
>
> I would much prefer that you add a parameter to the macro to avoid forcing
> a non-flexible and non-obvious variable definition wherever it is used.
> What I mean is something like:
>
> #define MPSC_RXRE_SIZE(d) dma_get_cache_alignment(d)
>
> Similarly for all of the other macros and where they're used.
Agreed. Except for that the patch looks fine to me, though.
next prev parent reply other threads:[~2017-10-19 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1508227542-13165-1-git-send-email-chenhc@lemote.com>
[not found] ` <1508227542-13165-5-git-send-email-chenhc@lemote.com>
2017-10-17 9:43 ` [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment() Sergei Shtylyov
2017-10-18 19:54 ` Alan Cox
2017-10-18 13:03 ` Tejun Heo
2017-10-19 7:52 ` Matt Redfearn
2017-10-19 7:52 ` Matt Redfearn
[not found] ` <CGME20171017080448epcas5p2c7c53292d84838f6d06e78abf4416729@epcas5p2.samsung.com>
[not found] ` <1508227542-13165-4-git-send-email-chenhc@lemote.com>
2017-10-17 11:55 ` [PATCH V8 4/5] libsas: Align SMP req/resp " Marek Szyprowski
2017-10-19 15:12 ` Christoph Hellwig
2017-10-20 0:04 ` kbuild test robot
2017-10-20 0:04 ` kbuild test robot
2017-10-18 17:23 ` [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment() Mark Greer
2017-10-19 15:09 ` Christoph Hellwig [this message]
[not found] ` <1508227542-13165-3-git-send-email-chenhc@lemote.com>
2017-10-19 15:10 ` [PATCH V8 3/5] scsi: Align block queue to dma_get_cache_alignment() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019150921.GB24204@lst.de \
--to=hch@lst.de \
--cc=agross@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chenhc@lemote.com \
--cc=ivan@ru.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=mgreer@animalcreek.com \
--cc=michael.chan@broadcom.com \
--cc=mst@mellanox.co.il \
--cc=pawel@osciak.com \
--cc=r.baldyga@hackerion.com \
--cc=ralf@linux-mips.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=tj@kernel.org \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox