From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Matt Redfearn <matt.redfearn@mips.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
James Hogan <james.hogan@mips.com>,
linux-mips@linux-mips.org, James Hogan <jhogan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clockevents: Retry programming min delta up to 10 times
Date: Thu, 19 Oct 2017 17:04:48 +0200 [thread overview]
Message-ID: <20171019170448.4637f480@mschwideX1> (raw)
In-Reply-To: <alpine.DEB.2.20.1710191527570.1971@nanos>
On Thu, 19 Oct 2017 15:29:28 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 19 Oct 2017, Matt Redfearn wrote:
> > On 19/10/17 13:43, Thomas Gleixner wrote:
> > > delta = 0;
> > > for (i = 0; i < 10; i++) {
> > > delta += dev->min_delta_ns;
> > > dev->next_event = ktime_add_ns(ktime_get(), delta);
> > > clc = .....
> > > .....
> > >
> > > That makes it more likely to succeed fast. Hmm?
> >
> > That will set the target time to increasing multiples of min_delta_ns in the
> > future, right?
>
> Yes, but without fiddling with min_delta_ns itself.
Grumpf, more extra code for yet another piece of broken hardware
I guess.
> > Sure, it should make it succeed faster - I'll make it like
> > that. Are you OK with the arbitrarily chosen 10 retries?
>
> I lost my crystalball so I have to trust yours :)
The alternative implementation would be to do the retries in
the clockevent driver itself. Then that particular driver can
choose the correct number of retries, no?
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2017-10-19 15:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 11:55 [PATCH 1/3] clockevents: Retry programming min delta up to 10 times Matt Redfearn
2017-10-19 11:55 ` Matt Redfearn
2017-10-19 11:55 ` [PATCH 2/3] clocksource/mips-gic-timer: Remove pointless irq_save,restore Matt Redfearn
2017-10-19 11:55 ` Matt Redfearn
2017-10-19 13:23 ` Daniel Lezcano
2017-10-19 21:57 ` Daniel Lezcano
2017-10-19 11:55 ` [PATCH V2 3/3] clocksource: mips-gic-timer: Add fastpath for local timer updates Matt Redfearn
2017-10-19 11:55 ` Matt Redfearn
2017-10-19 13:31 ` Daniel Lezcano
2017-10-19 12:43 ` [PATCH 1/3] clockevents: Retry programming min delta up to 10 times Thomas Gleixner
2017-10-19 13:21 ` Matt Redfearn
2017-10-19 13:21 ` Matt Redfearn
2017-10-19 13:29 ` Thomas Gleixner
2017-10-19 14:17 ` [PATCH v2] " Matt Redfearn
2017-10-19 14:17 ` Matt Redfearn
2017-10-19 15:04 ` Martin Schwidefsky [this message]
2017-10-19 15:11 ` [PATCH 1/3] " Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019170448.4637f480@mschwideX1 \
--to=schwidefsky@de.ibm.com \
--cc=daniel.lezcano@linaro.org \
--cc=james.hogan@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@mips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox