From: James Hogan <jhogan@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Huacai Chen <chenhc@lemote.com>,
Ralf Baechle <ralf@linux-mips.org>,
"Steven J . Hill" <Steven.Hill@cavium.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Jayachandran C <jchandra@broadcom.com>
Subject: Re: [PATCH 2/2] MIPS: Loongson64: Add cache_sync to loongson_dma_map_ops
Date: Wed, 24 Jan 2018 15:03:05 +0000 [thread overview]
Message-ID: <20180124150304.GG5446@saruman> (raw)
In-Reply-To: <20180124141144.GB25393@lst.de>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Wed, Jan 24, 2018 at 03:11:44PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 24, 2018 at 02:02:35PM +0000, James Hogan wrote:
> > On Thu, Nov 16, 2017 at 04:35:55PM +0800, Huacai Chen wrote:
> > > To support coherent & non-coherent DMA co-exsistance, we should add
> > > cache_sync to loongson_dma_map_ops.
> > >
> > > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> >
> > I presume this was broken by commit c9eb6172c328 ("dma-mapping: turn
> > dma_cache_sync into a dma_map_ops method") in 4.15-rc1? (Christoph Cc'd)
>
> I don't think that is the case.
>
> In mips only mips_default_dma_map_ops supports DMA_ATTR_NON_CONSISTENT,
> and mips_default_dma_map_ops grew support for the dma_cache_sync
> operation.
>
> Neither Octeon nor longsoon respect the DMA_ATTR_NON_CONSISTENT argument
> to dma_alloc_attrs, so there is no point in implementing dma_cache_sync
> for them.
I see, that makes sense. Thanks Christoph. I'll assume this patch isn't
applicable then unless Huacai adds some explanation.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-24 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 8:35 [PATCH 2/2] MIPS: Loongson64: Add cache_sync to loongson_dma_map_ops Huacai Chen
2018-01-24 14:02 ` James Hogan
2018-01-24 14:11 ` Christoph Hellwig
2018-01-24 15:03 ` James Hogan [this message]
2018-01-24 15:29 ` Christoph Hellwig
2018-01-25 7:09 ` Huacai Chen
2018-01-25 7:55 ` James Hogan
2018-01-25 8:44 ` Huacai Chen
2018-01-25 10:54 ` James Hogan
2018-01-25 11:04 ` Huacai Chen
2018-01-25 12:31 ` James Hogan
2018-01-26 7:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124150304.GG5446@saruman \
--to=jhogan@kernel.org \
--cc=Steven.Hill@cavium.com \
--cc=chenhc@lemote.com \
--cc=hch@lst.de \
--cc=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox