From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 13 Mar 2018 18:20:15 +0100 (CET) Received: from mail.kernel.org ([198.145.29.99]:46000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990434AbeCMRUAj4Psg (ORCPT ); Tue, 13 Mar 2018 18:20:00 +0100 Received: from saruman (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B71D1205F4; Tue, 13 Mar 2018 17:19:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B71D1205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jhogan@kernel.org Date: Tue, 13 Mar 2018 17:19:28 +0000 From: James Hogan To: Florian Fainelli Cc: linux-mips@linux-mips.org, david.daney@cavium.com, paul.burton@mips.com, Ralf Baechle , Kevin Cernekee , Huacai Chen , Jiaxun Yang , Bart Van Assche , Doug Ledford , open list Subject: Re: [PATCH 2/2] MIPS: Update dma-coherence.h files Message-ID: <20180313171927.GH21642@saruman> References: <1516758010-7641-1-git-send-email-f.fainelli@gmail.com> <1516758010-7641-3-git-send-email-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFBW6CQlri5Qm8JQ" Content-Disposition: inline In-Reply-To: <1516758010-7641-3-git-send-email-f.fainelli@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 62964 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jhogan@kernel.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips --nFBW6CQlri5Qm8JQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Tue, Jan 23, 2018 at 05:40:10PM -0800, Florian Fainelli wrote: > diff --git a/arch/mips/include/asm/mach-ath25/dma-coherence.h b/arch/mips/include/asm/mach-ath25/dma-coherence.h > index d5defdde32db..63bce15fa54d 100644 > --- a/arch/mips/include/asm/mach-ath25/dma-coherence.h > +++ b/arch/mips/include/asm/mach-ath25/dma-coherence.h > +#define plat_unmap_dma_mem plat_unmap_dma_mem > static inline void > plat_unmap_dma_mem(struct device *dev, dma_addr_t dma_addr, size_t size, > enum dma_data_direction direction) > { > } This could presumably be removed too. > diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h > index 9110988b92a1..165e13aba3ff 100644 > --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h > +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h > +#define phys_to_dma phys_to_dma > dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr); > +#define dma_to_phys dma_to_phys > phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr); I suppose these #defines can be dropped since commit ea8c64ace866 ("dma-mapping: move swiotlb arch helpers to a new header"). > diff --git a/arch/mips/include/asm/mach-loongson64/dma-coherence.h b/arch/mips/include/asm/mach-loongson64/dma-coherence.h > index 1602a9e9e8c2..0a9bbc4c1449 100644 > --- a/arch/mips/include/asm/mach-loongson64/dma-coherence.h > +++ b/arch/mips/include/asm/mach-loongson64/dma-coherence.h > +#define phys_to_dma phys_to_dma > extern dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr); > +#define dma_to_phys dma_to_phys > extern phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr); same here > +#define plat_dma_supported plat_dma_supported > static inline int plat_dma_supported(struct device *dev, u64 mask) > { > /* > @@ -69,6 +70,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask) > return 1; > } That can be removed too, no? Cheers James --nFBW6CQlri5Qm8JQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlqoCBoACgkQbAtpk944 dnquCRAAlu6XQSUMxkcAhSlf2aUyMkX+OGAvymFtCDCLFPlgx1+Rf4wCGmg/jzPB SwWOAOG5BGohSwQE8ydW0uA6X4yegRIuqag4byGOwdOs6mqqnLYUu3eAzZN/5aVc YFinonmpK0dZ4jlSPaOwfrngvVOlv5On9UMd4h8q5TFViWCcDjl4wfffxudY07tO fHYVr05gFUthZ80Rpu466z/BO8Lk/Sbs+E0LMZJY7JihpoTqfnbYVwMuHVp1qJ3a k2UsWIug3EyYwlTFMjap3Khq7m8MzYoSzj6B/0Y+1E2ZQTe5VNrxneQ+TJSPYVn0 H84YeXL7C3d3g/K31jQ984WMiZnQDaiOy91nvVVw+dVAvpJjMRhZfPWanaEEMWrY 0Fw64u/UOSg/lch/1FEy/hnB2Ig9ZTrOx7O48U47QJNAUiPGuqdzj1OCUpewOeXB /nzl5mOzSaLuPyNQr9rCSkj9xVIjJURkaWFeowYIjfOzKcA7pGM7jqk/OU0+ybur SaHB8TW3kM7www/WWvO78Hkel/LHOKPZcogC9XLddi7jhxjYZkdIoYSmw6nk6W8l Vj06Td6PHJtukzpxyng9hBJyNAnqlcMhxmUj/ro/xwznVCY9CuHmr4zwLOLtYwc5 cnW1P44A5vjJiZtH536cWfUG1oNeInG5GH3UAwZdNVNabjWzh/A= =Xkh4 -----END PGP SIGNATURE----- --nFBW6CQlri5Qm8JQ--