From: James Hogan <jhogan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [GIT PULL] MIPS fixes for 4.16-rc7
Date: Fri, 23 Mar 2018 20:56:48 +0000 [thread overview]
Message-ID: <20180323205647.GC11796@saruman> (raw)
In-Reply-To: <CA+55aFwERU7m_DYffR=xcUmb1_mzzqwU2gK7xOck8X4N9CtLCw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Fri, Mar 23, 2018 at 11:36:29AM -0700, Linus Torvalds wrote:
> On Fri, Mar 23, 2018 at 3:26 AM, James Hogan <jhogan@kernel.org> wrote:
> >
> > arch/mips/lantiq/Kconfig | 2 ++
> > arch/mips/lantiq/xway/sysctrl.c | 6 ++---
> > arch/mips/ralink/mt7621.c | 50 +++++++++++++++++++++--------------------
> > arch/mips/ralink/reset.c | 7 ------
> > 4 files changed, 31 insertions(+), 34 deletions(-)
>
> Odd. This didn't match for me. It turns out that's because you have
> the patience diff enabled.
>
> Normally the patience diff generates moire legible diffs, but in this
> case the default diff actually seems better.
>
> You don't have to do anything about your config, I realize that some
> people and projects prefer patience-dff. I just found it interesting
> how *completely* different the diffs look. Normally the differences
> are subtler.
Indeed I do have patience enabled from long ago when the default diff
was probably showing some change unintuitively.
The only nice thing I suppose is that it emphasises the added __sync()
and its choice of code to show as moved is essentially unchanged, but
then again it doesn't match so closely how the author has described the
change...
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-03-23 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:26 [GIT PULL] MIPS fixes for 4.16-rc7 James Hogan
2018-03-23 18:36 ` Linus Torvalds
2018-03-23 20:56 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323205647.GC11796@saruman \
--to=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox