Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: James Hogan <jhogan@kernel.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Maxim Uvarov <muvarov@gmail.com>,
	linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: Make the default for PHYSICAL_START always 64-bit
Date: Tue, 27 Mar 2018 10:24:38 +0100	[thread overview]
Message-ID: <20180327092438.GA17660@saruman> (raw)
In-Reply-To: <alpine.DEB.2.00.1803240129140.2163@tp.orcam.me.uk>

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Mon, Mar 26, 2018 at 07:11:51PM +0100, Maciej W. Rozycki wrote:
> Make the default for PHYSICAL_START always 64-bit, ensuring that a 
> correct sign-extended value is used if a 32-bit image is loaded by a 
> 64-bit system, and matching how the load address is set in platform 
> Makefile fragments (arch/mips/*/Platform) in the absence of the 
> PHYSICAL_START configuration option.

This looks correct given the defaults in the Makefile fragments. However
I presume a 32BIT kernel will produce a 32-bit ELF, in which case the
result will be indistinguishable? For other kernel image formats which
always use 64-bit pointers perhaps it matters more (if they can be
loaded by kexec-tools). uImage is 32-bit ISTR, and our ITB stuff seems
to only use 32bit addresses for CONFIG_32BIT. I don't now about other
formats.

So unless I hear otherwise I'll probably drop the stable tag and apply
for 4.17.

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-03-27  9:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 18:11 [PATCH] MIPS: Make the default for PHYSICAL_START always 64-bit Maciej W. Rozycki
2018-03-26 18:11 ` Maciej W. Rozycki
2018-03-27  9:24 ` James Hogan [this message]
2018-03-27 11:07   ` Maciej W. Rozycki
2018-03-27 11:07     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327092438.GA17660@saruman \
    --to=jhogan@kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@mips.com \
    --cc=muvarov@gmail.com \
    --cc=ralf@linux-mips.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox