From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 11 Apr 2018 11:54:23 +0200 (CEST) Received: from mail.kernel.org ([198.145.29.99]:57610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990493AbeDKJyQLF8N3 (ORCPT ); Wed, 11 Apr 2018 11:54:16 +0200 Received: from saruman (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44ABD21725; Wed, 11 Apr 2018 09:54:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44ABD21725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jhogan@kernel.org Date: Wed, 11 Apr 2018 10:54:00 +0100 From: James Hogan To: Arnd Bergmann Cc: "open list:RALINK MIPS ARCHITECTURE" , Paul Burton , Maciej Rozycki , linux-arch , Andrew Morton , Linux Kbuild mailing list , Vineet Gupta , Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , Geert Uytterhoeven , "David S. Miller" , Christopher Li , Thomas Gleixner , Peter Zijlstra , Kees Cook , Ingo Molnar , Josh Poimboeuf , Will Deacon , "Steven Rostedt (VMware)" , Mark Rutland , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux Kernel Mailing List , linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, sparclinux , linux-sparse@vger.kernel.org Subject: Re: [PATCH] bug.h: Work around GCC PR82365 in BUG() Message-ID: <20180411095359.GB21429@saruman> References: <20171219114112.939391-1-arnd@arndb.de> <20180410224805.GA21429@saruman> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 63488 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jhogan@kernel.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips --i9LlY+UWpKt15+FH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 11, 2018 at 09:30:56AM +0200, Arnd Bergmann wrote: > On Wed, Apr 11, 2018 at 12:48 AM, James Hogan wrote: > > Before I forward port those patches to add .insn for MIPS, is that sort > > of approach (an arch specific asm/compiler-gcc.h to allow MIPS to > > override barrier_before_unreachable()) an acceptable fix? >=20 > That sounds fine to me. However, I would suggest making that > asm/compiler.h instead of asm/compiler-gcc.h, so we can also > use the same file to include workarounds for clang if needed. Yes, though there are a few asm/compiler.h's already, and the alpha one includes linux/compiler.h before undefining inline, so seems to have its own specific purpose... Cheers James --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlrN2zcACgkQbAtpk944 dnq4xQ//W/rBEEvKM2KXaxuW0aYIu5tRiVtFhDs8mABCrU7S1CieiW/jwb/hvMpi y8FpHCqjEIAaLlZT/yv+05QHtPiT8I5+3EcJJmUMpXxXGAAZV1V9IZ3gCM3U9B0G NoNYHD5kxjf+JX/+47P8hcG5dREp2TmUYrIZ8USYbXkc/jcCCrJfNra/I2OLY9lQ sw5V67uUE+0CE83n2yGrFLmb2Nh9tIIPo7DTvS7ZmBV0mc2ltU8wwPbkKtpfqEOq YSF3+2AvJrt9TWpudwuxIp7wnhNWAdOGPiSyDTSdYzK02US8cC1l3KHMswzIbhNK YCrVHl7U0fa1wx2ka6cbNepnxRUd9lfX64Cs5SsjomgDiItcJJNqkSWijwETm/wh ZWJids6oj6KYdNDwasNr096sv9S+3+IuVwLVcVtSyN9UHfkfJGAeLubT5JJYG9QH OR4I0Gdcy2/aH9o+vvvmQFyrNa4yBPNHyl6EsToI8aa+gWqg1wcRROABBxcdElgn mMBLQ9kruLIp8M6ucVTtowe9u7OzP92lCH1pQhh3yD6rgwUUAeNarxRg2Pim8OiL B+4S/GODXOUXZyaku7wbaDf4IL3nhArScsspzepnyo//ZOhz69beRfDExDT2gTJk k7YWsQxMpdhQJpi+XBhDPAHGx+lq4mIK01pMgtp0IGoh59aTTsE= =OyoV -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org ([198.145.29.99]:57610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990493AbeDKJyQLF8N3 (ORCPT ); Wed, 11 Apr 2018 11:54:16 +0200 Date: Wed, 11 Apr 2018 10:54:00 +0100 From: James Hogan Subject: Re: [PATCH] bug.h: Work around GCC PR82365 in BUG() Message-ID: <20180411095359.GB21429@saruman> References: <20171219114112.939391-1-arnd@arndb.de> <20180410224805.GA21429@saruman> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Content-Disposition: inline In-Reply-To: Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Arnd Bergmann Cc: "open list:RALINK MIPS ARCHITECTURE" , Paul Burton , Maciej Rozycki , linux-arch , Andrew Morton , Linux Kbuild mailing list , Vineet Gupta , Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , Geert Uytterhoeven , "David S. Miller" , Christopher Li , Thomas Gleixner , Peter Zijlstra , Kees Cook , Ingo Molnar , Josh Poimboeuf , Will Deacon , "Steven Rostedt (VMware)" , Mark Rutland , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux Kernel Mailing List , linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, sparclinux , linux-sparse@vger.kernel.org Message-ID: <20180411095400.yS0sD_aUAf3UKX4kWJ-ZreiZP8ESucNWjbStOPJ5sxg@z> --i9LlY+UWpKt15+FH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 11, 2018 at 09:30:56AM +0200, Arnd Bergmann wrote: > On Wed, Apr 11, 2018 at 12:48 AM, James Hogan wrote: > > Before I forward port those patches to add .insn for MIPS, is that sort > > of approach (an arch specific asm/compiler-gcc.h to allow MIPS to > > override barrier_before_unreachable()) an acceptable fix? >=20 > That sounds fine to me. However, I would suggest making that > asm/compiler.h instead of asm/compiler-gcc.h, so we can also > use the same file to include workarounds for clang if needed. Yes, though there are a few asm/compiler.h's already, and the alpha one includes linux/compiler.h before undefining inline, so seems to have its own specific purpose... Cheers James --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlrN2zcACgkQbAtpk944 dnq4xQ//W/rBEEvKM2KXaxuW0aYIu5tRiVtFhDs8mABCrU7S1CieiW/jwb/hvMpi y8FpHCqjEIAaLlZT/yv+05QHtPiT8I5+3EcJJmUMpXxXGAAZV1V9IZ3gCM3U9B0G NoNYHD5kxjf+JX/+47P8hcG5dREp2TmUYrIZ8USYbXkc/jcCCrJfNra/I2OLY9lQ sw5V67uUE+0CE83n2yGrFLmb2Nh9tIIPo7DTvS7ZmBV0mc2ltU8wwPbkKtpfqEOq YSF3+2AvJrt9TWpudwuxIp7wnhNWAdOGPiSyDTSdYzK02US8cC1l3KHMswzIbhNK YCrVHl7U0fa1wx2ka6cbNepnxRUd9lfX64Cs5SsjomgDiItcJJNqkSWijwETm/wh ZWJids6oj6KYdNDwasNr096sv9S+3+IuVwLVcVtSyN9UHfkfJGAeLubT5JJYG9QH OR4I0Gdcy2/aH9o+vvvmQFyrNa4yBPNHyl6EsToI8aa+gWqg1wcRROABBxcdElgn mMBLQ9kruLIp8M6ucVTtowe9u7OzP92lCH1pQhh3yD6rgwUUAeNarxRg2Pim8OiL B+4S/GODXOUXZyaku7wbaDf4IL3nhArScsspzepnyo//ZOhz69beRfDExDT2gTJk k7YWsQxMpdhQJpi+XBhDPAHGx+lq4mIK01pMgtp0IGoh59aTTsE= =OyoV -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH--