From: Greg KH <gregkh@linuxfoundation.org>
To: James Hogan <jhogan@kernel.org>
Cc: alexander.levin@microsoft.com, linux-mips@linux-mips.org,
matt.redfearn@mips.com, paul.burton@mips.com,
ralf@linux-mips.org, stable-commits@vger.kernel.org
Subject: Re: Patch "MIPS: generic: Fix machine compatible matching" has been added to the 4.14-stable tree
Date: Thu, 26 Apr 2018 08:55:21 +0200 [thread overview]
Message-ID: <20180426065521.GA14025@kroah.com> (raw)
In-Reply-To: <20180425220221.GB25917@saruman>
On Wed, Apr 25, 2018 at 11:02:21PM +0100, James Hogan wrote:
> On Tue, Apr 24, 2018 at 05:01:06PM +0200, gregkh@linuxfoundation.org wrote:
> > We now have a platform (Ranchu) in the "generic" platform which matches
>
> The reason I didn't tag stable was because Ranchu was added in 4.16 ...
>
> > if (!mach->matches)
> > return NULL;
>
> ... so mach->matches will always be NULL before 4.16 ...
>
> >
> > - for (match = mach->matches; match->compatible; match++) {
> > + for (match = mach->matches; match->compatible[0]; match++) {
>
> ... so this can't get hit.
>
> Feel free to drop, otherwise it does no harm, its dead code.
Now dropped, thanks for letting me know.
greg k-h
next prev parent reply other threads:[~2018-04-26 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:01 Patch "MIPS: generic: Fix machine compatible matching" has been added to the 4.14-stable tree gregkh
2018-04-24 15:01 ` gregkh
2018-04-25 22:02 ` James Hogan
2018-04-26 6:55 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-01 23:48 gregkh
2018-05-01 23:48 ` gregkh
2018-05-27 15:14 gregkh
2018-05-27 15:14 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426065521.GA14025@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.levin@microsoft.com \
--cc=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@mips.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=stable-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox