Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Paul Burton <paul.burton@mips.com>
Cc: Darren Hart <dvhart@linux.intel.com>,
	netdev@vger.kernel.org, linux-mips@linux-mips.org,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()
Date: Fri, 11 May 2018 21:24:46 +0200	[thread overview]
Message-ID: <20180511192446.GD12738@lunn.ch> (raw)
In-Reply-To: <20180511182502.y74wm6dmtf3dbcln@pburton-laptop>

> I could reorder the probe function a little to initialize the PHY before
> performing the MAC reset, drop this patch and the AR803X hibernation
> stuff from patch 2 if you like. But again, I can't actually test the
> result on the affected hardware.

Hi Paul

I don't like a MAC driver poking around in PHY registers.

So if you can rearrange the code, that would be great.

   Thanks
	Andrew

  parent reply	other threads:[~2018-05-14 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180510231657.28503-1-paul.burton@mips.com>
     [not found] ` <20180510231657.28503-2-paul.burton@mips.com>
2018-05-11  0:26   ` [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask() Andrew Lunn
     [not found]     ` <20180511182502.y74wm6dmtf3dbcln@pburton-laptop>
2018-05-11 19:24       ` Andrew Lunn [this message]
     [not found]         ` <20180511222239.aznt4ngtnrbnvshf@pburton-laptop>
2018-05-12 21:37           ` Andrew Lunn
     [not found] ` <20180510231657.28503-7-paul.burton@mips.com>
2018-05-11  0:28   ` [PATCH v6 6/6] MIPS: Boston: Adjust DT for pch_gbe PHY support Andrew Lunn
2018-05-11  0:35   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511192446.GD12738@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dvhart@linux.intel.com \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.burton@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox