From: Ralf Baechle <ralf@linux-mips.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: paul.burton@mips.com, jhogan@kernel.org,
linux-mips@linux-mips.org, ak@linux.intel.com,
Matthew Fortune <mfortune@gmail.com>
Subject: Re: [PATCH] MIPS: define __current_thread_info inside of function
Date: Mon, 2 Jul 2018 15:54:42 +0200 [thread overview]
Message-ID: <20180702135442.GB431230@linux-mips.org> (raw)
In-Reply-To: <20180616155815.31230-1-hauke@hauke-m.de>
On Sat, Jun 16, 2018 at 05:58:15PM +0200, Hauke Mehrtens wrote:
> __current_thread_info is currently defined in the header file, but when
> we link the kernel with LTO it shows up in all files which include this
> header file and causes conflicts with itself. Move the definition into
> the only function which uses it to prevent these problems.
>
> This fixes the build with LTO.
Not a new issue, see
https://git.linux-mips.org/cgit/ralf/linux-lto.git/commit/arch/mips/include/asm/thread_info.h?id=969890d139ee53f61fc6ed3f534335802c733e1b
This was never upstreamed since LTO never received much love from upstream
back then and there might be more well ripened code in there.
To me this appeared like a compiler issue; I think this global register
variable should be treated like a cmmon variable.
Maybe Matthew can shed some light on this?
Ralf
prev parent reply other threads:[~2018-07-02 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 15:58 [PATCH] MIPS: define __current_thread_info inside of function Hauke Mehrtens
2018-07-02 13:54 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702135442.GB431230@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ak@linux.intel.com \
--cc=hauke@hauke-m.de \
--cc=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mfortune@gmail.com \
--cc=paul.burton@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox