From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 12 Oct 2018 12:40:09 +0200 (CEST) Received: from mail-wm1-x342.google.com ([IPv6:2a00:1450:4864:20::342]:38090 "EHLO mail-wm1-x342.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992066AbeJLKkFNzaWQ (ORCPT ); Fri, 12 Oct 2018 12:40:05 +0200 Received: by mail-wm1-x342.google.com with SMTP id 193-v6so12410536wme.3; Fri, 12 Oct 2018 03:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P4FMXU+dr2OS/jhn7+79OVEFnzX+vIBjUnpiLGCuw2w=; b=RnadBu+YR3q3S7N9VEPJTIwzNH0dr4wvWJZmLhEdT2fMAp/3rTVaI+ApDgcgvVvcyC ZJc9pfW6gs8AjU9mT8CvnvV2Px+NusXBZaYTFB5tD/g8wIY829Yi4OvRCnmsCu4mkqRQ Tmcy4ukdf2s9zx0D7iaifYeGlV7jAIZL6IrD9hcVXb5NX4Z/MhMteGWj+m3Kz6bYaz24 LZQe80pDI2YtMd0qHL7HiblzUZ4c+y37W5bCbzgFg34GUJpZZj2L3614JHz2wOe0/Luj fskseEwfOFXo35di4ZOK3r4M3edwHGB7XyUsrOA1fAsFjcagrbZElZvBzs3BWtq3X2vM QBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P4FMXU+dr2OS/jhn7+79OVEFnzX+vIBjUnpiLGCuw2w=; b=e6YPS+hXpfpRIyXrtGU7GSlg7CsWx6d42ZigEZulQhukjzaRRo55MxjgdWNkq1Tu2/ mTF7RgVM7TP/tSKsHWcDPvo0sWGAS8CNGItTAwxsHGTXLq1OooSHdPIMwNvXLMAmcyyZ T+AlUKQfuG1kWj+hSsIOyCtZTlMzrHQWs+H66cpZfRj49g+stgulevezCQ8Kp2wbeva5 IlaO/KR4BkpBs8f768TWhMBPgRf1R4HH2dHW2Dft272f/Oldi5dNRT4OZ8kdNBTrtim3 mT2tinI1nRO5z2G2trPnDw2RT5/Fhva4Nr64b1+7GRAe6tWhMSP633+4QTZfD1TdcFke ftXg== X-Gm-Message-State: ABuFfojxUA8R9uszdn2a3tWxzoPr1rEtZu2kwAGaSK34FpJLDJt+H63D 2QQJHMjD7HsxhmkUq91NKuY= X-Google-Smtp-Source: ACcGV62S3HkJvdTRDL250zivG74jUNgIPfDtULo1wA0m8CxOHtaRGIyGya9hD7dW4SzJZcmsIbX4zg== X-Received: by 2002:a1c:6355:: with SMTP id x82-v6mr4960967wmb.145.1539340799194; Fri, 12 Oct 2018 03:39:59 -0700 (PDT) Received: from localhost (p2E5BEEEA.dip0.t-ipconnect.de. [46.91.238.234]) by smtp.gmail.com with ESMTPSA id s7-v6sm8552340wmd.0.2018.10.12.03.39.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 03:39:58 -0700 (PDT) Date: Fri, 12 Oct 2018 12:39:57 +0200 From: Thierry Reding To: Paul Cercueil Cc: Thomas Gleixner , Daniel Lezcano , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Jonathan Corbet , od@zcrc.me, Mathieu Malaterre , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-mips@linux-mips.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v7 12/24] pwm: jz4740: Use regmap and clocks from TCU driver Message-ID: <20181012103957.GF9162@ulmo> References: <20180821171635.22740-1-paul@crapouillou.net> <20180821171635.22740-13-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H4SyuGOnfnj3aJqJ" Content-Disposition: inline In-Reply-To: <20180821171635.22740-13-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66759 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: thierry.reding@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips --H4SyuGOnfnj3aJqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 21, 2018 at 07:16:23PM +0200, Paul Cercueil wrote: > The ingenic-timer "TCU" driver provides us with a regmap, that we can > use to safely access the TCU registers. >=20 > It also provides us with clocks, that can be (un)gated, reparented or > reclocked from devicetree, instead of having these settings hardcoded in > this driver. >=20 > While this driver is devicetree-compatible, it is never (as of now) > probed from devicetree, so this change does not introduce a ABI problem > with current devicetree files. >=20 > Signed-off-by: Paul Cercueil > --- >=20 > Notes: > v5: New patch > =20 > v6: Drop requirement of probing from devicetree > =20 > v7: No change >=20 > drivers/pwm/Kconfig | 2 + > drivers/pwm/pwm-jz4740.c | 124 +++++++++++++++++++++++++++++++----------= ------ > 2 files changed, 83 insertions(+), 43 deletions(-) >=20 > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index a4d262db9945..58359bf22b96 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -202,6 +202,8 @@ config PWM_IMX > config PWM_JZ4740 > tristate "Ingenic JZ47xx PWM support" > depends on MACH_INGENIC > + depends on COMMON_CLK > + select INGENIC_TIMER > help > Generic PWM framework driver for Ingenic JZ47xx based > machines. > diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c > index a7b134af5e04..1bda8d8e9865 100644 > --- a/drivers/pwm/pwm-jz4740.c > +++ b/drivers/pwm/pwm-jz4740.c > @@ -14,21 +14,21 @@ > */ > =20 > #include > +#include Why do you need this? Thierry --H4SyuGOnfnj3aJqJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlvAef0ACgkQ3SOs138+ s6Etkw/8CDqjDhw3dT5o3iLxU8WHHcL1syZVxtoMp8myKzUL83S+RIRFfWhrXYrg 0GoMLZCuuq5YQAFmH2IyOrcyQNP8za88WJmW6ahO5rUj2dToorEqD2kijC8Z1YY4 gJBm2OpTKROOUoZdP3fUkcLsJradOzua+wrzHeKkIOwleWWIRC4yXnfkPSlvYdAH 0ul5Nhteg6ulN25WE8uPEFGqWPgMAA0+tU64/COQ4V9Yg7P5YJbERNax72Dm7v0N eIppDnmtbVtt+SvJ+QAM8NgZogMhJnkdf8T7Ax8UPGMG6JSxmVsSz0hCMB5IVenF Lfp5u68cXO6hxyhku3ss4nthU8QMprEsM55chBEHvXyH7+4IsB6U+WEfc5tGxxN+ AJcQgan0mRO179DjdCYtxcELpJVRLglzhpjTIJisip+Kp0WtxJPd7wYtovMVlEHl VyqEXCearUquqFdJ3R20ZN5sUanv5miTaK9QpNYdQrkCv9t3/KK5KdutUZDpyDD7 3kubTcLr4W3cSqwrq2GJF6KV+9b6VdLUeZgmPHvAj/81pfHFb3j7Q9gmjJLgGgBr tVNXoCLSOaWWya9qrLPeKoZmm90zG3NpEoyExycPdai8qDGLIuhOspNZ7SG/ixFw eKm2sG95UCmCkGVSaIUVTZRgslDEv63kjKKG6qoza9kEMRjmqCg= =TBBW -----END PGP SIGNATURE----- --H4SyuGOnfnj3aJqJ--