From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Paul Burton <paul.burton@mips.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"ast@kernel.org" <ast@kernel.org>
Cc: Jiong Wang <jiong.wang@netronome.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"oss-drivers@netronome.com" <oss-drivers@netronome.com>,
Markos Chandras <markos.chandras@imgtec.com>,
Paul Burton <pburton@wavecomp.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2 bpf] mips: bpf: fix encoding bug for mm_srlv32_op
Date: Mon, 3 Dec 2018 15:55:45 -0800 [thread overview]
Message-ID: <20181203155545.6eb5520a@cakuba.netronome.com> (raw)
In-Reply-To: <MWHPR2201MB1277C127DA9E9CABBC6F96BEC1AE0@MWHPR2201MB1277.namprd22.prod.outlook.com>
On Mon, 3 Dec 2018 22:42:04 +0000, Paul Burton wrote:
> Jiong Wang wrote:
> > For micro-mips, srlv inside POOL32A encoding space should use 0x50
> > sub-opcode, NOT 0x90.
> >
> > Some early version ISA doc describes the encoding as 0x90 for both srlv and
> > srav, this looks to me was a typo. I checked Binutils libopcode
> > implementation which is using 0x50 for srlv and 0x90 for srav.
> >
> > v1->v2:
> > - Keep mm_srlv32_op sorted by value.
> >
> > Fixes: f31318fdf324 ("MIPS: uasm: Add srlv uasm instruction")
> > Cc: Markos Chandras <markos.chandras@imgtec.com>
> > Cc: Paul Burton <paul.burton@mips.com>
> > Cc: linux-mips@vger.kernel.org
> > Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Acked-by: Song Liu <songliubraving@fb.com>
> > Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
>
> Applied to mips-fixes.
Newbie process related question - are the arch JIT patches routed via
arch trees or bpf-next? Jiong has more (slightly conflicting) JIT
patches to send - I wonder how they'll get applied and whether to wait
for the mips -> Linus -> net -> bpf merge chain.
next prev parent reply other threads:[~2018-12-03 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 22:27 [PATCH v2 bpf] mips: bpf: fix encoding bug for mm_srlv32_op Jiong Wang
2018-12-03 22:42 ` Paul Burton
2018-12-03 23:55 ` Jakub Kicinski [this message]
2018-12-04 0:06 ` Paul Burton
2018-12-04 0:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203155545.6eb5520a@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiong.wang@netronome.com \
--cc=linux-mips@vger.kernel.org \
--cc=markos.chandras@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox