From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2487EC64EB1 for ; Thu, 6 Dec 2018 21:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC2622081C for ; Thu, 6 Dec 2018 21:13:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="dsxztm+A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC2622081C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mips-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbeLFVNI (ORCPT ); Thu, 6 Dec 2018 16:13:08 -0500 Received: from mail.skyhub.de ([5.9.137.197]:40550 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbeLFVNI (ORCPT ); Thu, 6 Dec 2018 16:13:08 -0500 Received: from zn.tnic (p200300EC2BCE8F00A9C379089DD692CF.dip0.t-ipconnect.de [IPv6:2003:ec:2bce:8f00:a9c3:7908:9dd6:92cf]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3C9A91EC04DF; Thu, 6 Dec 2018 22:13:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1544130786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=kf/Pqa4+4o0O/tTGX0ewSkjvR0cGR6THt99q0WvHb9o=; b=dsxztm+A6X/3odCOjkdYcBaHYJlLoE+T5BtDfbq35fx799Lerj7XjTDBNllOGXOcl7G2DT tFucDl63WE9ZwxzKOEXLEzisRMxiv3qUiz7Dg3irZro9Pac8lmpuyLpWhpSR+PEp+ICIFF ovIHpEt+EbRiG4KifiRAz3hlv6LIQhc= Date: Thu, 6 Dec 2018 22:12:52 +0100 From: Borislav Petkov To: Christophe Leroy Cc: Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Yoshinori Sato , Richard Kuo , Michal Simek , Ralf Baechle , Paul Burton , James Hogan , Ley Foon Tan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Jason Wessel , Daniel Thompson , Douglas Anderson , Randy Dunlap , "Gustavo A. R. Silva" , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net Subject: Re: [PATCH v2 2/2] kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops Message-ID: <20181206211252.GJ3986@zn.tnic> References: <030d63848e4b0ef4d76ca24597ab8302a393d692.1544083483.git.christophe.leroy@c-s.fr> <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Dec 06, 2018 at 08:07:40PM +0000, Christophe Leroy wrote: > checkpatch.pl reports the following: > > WARNING: struct kgdb_arch should normally be const > #28: FILE: arch/mips/kernel/kgdb.c:397: > +struct kgdb_arch arch_kgdb_ops = { > > This report makes sense, as all other ops struct, this > one should also be const. This patch does the change. > > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Richard Kuo > Cc: Michal Simek > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: Ley Foon Tan > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: x86@kernel.org > Acked-by: Daniel Thompson > Acked-by: Paul Burton > Signed-off-by: Christophe Leroy > --- > v2: Added CCs to all maintainers/supporters identified by get_maintainer.pl and Acks from Daniel and Paul. > > arch/arc/kernel/kgdb.c | 2 +- > arch/arm/kernel/kgdb.c | 2 +- > arch/arm64/kernel/kgdb.c | 2 +- > arch/h8300/kernel/kgdb.c | 2 +- > arch/hexagon/kernel/kgdb.c | 2 +- > arch/microblaze/kernel/kgdb.c | 2 +- > arch/mips/kernel/kgdb.c | 2 +- > arch/nios2/kernel/kgdb.c | 2 +- > arch/powerpc/kernel/kgdb.c | 2 +- > arch/sh/kernel/kgdb.c | 2 +- > arch/sparc/kernel/kgdb_32.c | 2 +- > arch/sparc/kernel/kgdb_64.c | 2 +- > arch/x86/kernel/kgdb.c | 2 +- > include/linux/kgdb.h | 2 +- > 14 files changed, 14 insertions(+), 14 deletions(-) ... > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c > index 8e36f249646e..e7effc02f13c 100644 > --- a/arch/x86/kernel/kgdb.c > +++ b/arch/x86/kernel/kgdb.c > @@ -804,7 +804,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt) > (char *)bpt->saved_instr, BREAK_INSTR_SIZE); > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: */ > .gdb_bpt_instr = { 0xcc }, > .flags = KGDB_HW_BREAKPOINT, For the x86 bits: Acked-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.