From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Burton <paul.burton@mips.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, John Crispin <john@phrozen.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions
Date: Tue, 22 Jan 2019 20:29:16 +0100 [thread overview]
Message-ID: <20190122192916.GB5676@kroah.com> (raw)
In-Reply-To: <20190122192255.tjkmwgx25wvcp6y6@pburton-laptop>
On Tue, Jan 22, 2019 at 07:22:57PM +0000, Paul Burton wrote:
> Hello,
>
> On Tue, Jan 22, 2019 at 08:48:56PM +0200, Aaro Koskinen wrote:
> > On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote:
> > > -static int init_debufs(void)
> > > +static void init_debugfs(void)
> > > {
> > > - struct dentry *show_dentry;
> > > dir = debugfs_create_dir("oct_ilm", 0);
> > > - if (!dir) {
> > > - pr_err("oct_ilm: failed to create debugfs entry oct_ilm\n");
> > > - return -1;
> > > - }
> > > -
> > > - show_dentry = debugfs_create_file("statistics", 0222, dir, NULL,
> > > - &oct_ilm_ops);
> > > - if (!show_dentry) {
> > > - pr_err("oct_ilm: failed to create debugfs entry oct_ilm/statistics\n");
> > > - return -1;
> > > - }
> > > -
> > > - show_dentry = debugfs_create_file("reset", 0222, dir, NULL,
> > > - &reset_statistics_ops);
> > > - if (!show_dentry) {
> > > - pr_err("oct_ilm: failed to create debugfs entry oct_ilm/reset\n");
> > > - return -1;
> > > - }
> > > -
> > > + debugfs_create_file("statistics", 0222, dir, NULL, &oct_ilm_ops);
> > > + debugfs_create_file("reset", 0222, dir, NULL, &reset_statistics_ops);
> > > return 0;
> >
> > The return needs to be deleted now that the function is void.
>
> Well spotted - I'm happy to fix this up whilst applying the patch.
The fact that 0-day didn't catch this makes me worried, is this
platform/driver not being built there?
Thanks for catching this, sorry for the mistake.
greg k-h
next prev parent reply other threads:[~2019-01-22 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 14:57 [PATCH 0/5] mips: cleanup debugfs usage Greg Kroah-Hartman
2019-01-22 14:57 ` [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 18:48 ` Aaro Koskinen
2019-01-22 19:22 ` Paul Burton
2019-01-22 19:29 ` Greg Kroah-Hartman [this message]
2019-01-22 19:45 ` Paul Burton
2019-01-22 14:57 ` [PATCH 2/5] mips: ralink: " Greg Kroah-Hartman
2019-01-22 14:57 ` [PATCH 3/5] mips: mm: " Greg Kroah-Hartman
2019-01-22 14:57 ` [PATCH 4/5] mips: math-emu: " Greg Kroah-Hartman
2019-01-22 14:57 ` [PATCH 5/5] mips: kernel: " Greg Kroah-Hartman
2019-01-23 1:34 ` [PATCH 0/5] mips: cleanup debugfs usage Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122192916.GB5676@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=jhogan@kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).