From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5B9C10F06 for ; Tue, 26 Mar 2019 06:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 253DE2070B for ; Tue, 26 Mar 2019 06:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582575; bh=Ks82F6afs5miF/B6V7NV7PuKCBsXgMu4SoVTkBhz1hc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LtYHaXQzJECApoisGZgtR48kAtcGO5t3k78Ldqpxz8YJnAzQGGHspb1nJg0faBxqT 99o/ikgOUd8ghBlkgY1P/f2uR6UCvUlYHW4n3/2IxH6ZEFDdcqPEZz78QkrSaM0mVQ F0lmkCH1kFacrxHr2tUGq2yaXVSXn4HUs2gFulpQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732531AbfCZGi2 (ORCPT ); Tue, 26 Mar 2019 02:38:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:53104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732229AbfCZGi2 (ORCPT ); Tue, 26 Mar 2019 02:38:28 -0400 Received: from localhost (unknown [104.132.152.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B2462086C; Tue, 26 Mar 2019 06:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582307; bh=Ks82F6afs5miF/B6V7NV7PuKCBsXgMu4SoVTkBhz1hc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ms2ZeBMMAtNHwrdWlKOGuTUFWq1mhp2EUO8kDwMtHvIQHvAV/FnUTRTUCK6c3gv1/ 8mKwJroOn+A8PjLzczp/E86XqADCe0DQTfvmDMwBjlq5zXr6cJAs4+RYdCKt2TSkrn 9TL0Bkvn7Hu4n2CAmrubL/pXutz9TIURjNqqXsK0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Archer Yan , Paul Burton , linux-mips@vger.kernel.org Subject: [PATCH 5.0 16/52] MIPS: Fix kernel crash for R6 in jump label branch function Date: Tue, 26 Mar 2019 15:30:03 +0900 Message-Id: <20190326042701.724166031@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190326042700.963224437@linuxfoundation.org> References: <20190326042700.963224437@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Archer Yan commit 47c25036b60f27b86ab44b66a8861bcf81cde39b upstream. Insert Branch instruction instead of NOP to make sure assembler don't patch code in forbidden slot. In jump label function, it might be possible to patch Control Transfer Instructions(CTIs) into forbidden slot, which will generate Reserved Instruction exception in MIPS release 6. Signed-off-by: Archer Yan Reviewed-by: Paul Burton [paul.burton@mips.com: - Add MIPS prefix to subject. - Mark for stable from v4.0, which introduced r6 support, onwards.] Signed-off-by: Paul Burton Cc: linux-mips@vger.kernel.org Cc: stable@vger.kernel.org # v4.0+ Signed-off-by: Greg Kroah-Hartman --- arch/mips/include/asm/jump_label.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/arch/mips/include/asm/jump_label.h +++ b/arch/mips/include/asm/jump_label.h @@ -21,15 +21,15 @@ #endif #ifdef CONFIG_CPU_MICROMIPS -#define NOP_INSN "nop32" +#define B_INSN "b32" #else -#define NOP_INSN "nop" +#define B_INSN "b" #endif static __always_inline bool arch_static_branch(struct static_key *key, bool branch) { - asm_volatile_goto("1:\t" NOP_INSN "\n\t" - "nop\n\t" + asm_volatile_goto("1:\t" B_INSN " 2f\n\t" + "2:\tnop\n\t" ".pushsection __jump_table, \"aw\"\n\t" WORD_INSN " 1b, %l[l_yes], %0\n\t" ".popsection\n\t"