From: Dan Carpenter <dan.carpenter@oracle.com>
To: tbogendoerfer@suse.de
Cc: linux-mips@vger.kernel.org
Subject: [bug report] MIPS: SGI-IP27: rework HUB interrupts
Date: Wed, 27 Mar 2019 10:59:48 +0300 [thread overview]
Message-ID: <20190327075948.GA18472@kadam> (raw)
Hello Thomas Bogendoerfer,
This is a semi-automatic email about new static checker warnings.
The patch 69a07a41d908: "MIPS: SGI-IP27: rework HUB interrupts" from
Feb 19, 2019, leads to the following Smatch complaint:
arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq()
warn: variable dereferenced before check 'hd' (see line 121)
arch/mips/sgi-ip27/ip27-irq.c
117 static void shutdown_bridge_irq(struct irq_data *d)
118 {
119 struct hub_irq_data *hd = irq_data_get_irq_chip_data(d);
120 struct bridge_controller *bc;
121 int pin = hd->pin;
^^^^^^^
Dereference.
122
123 if (!hd)
^^^
Too late.
124 return;
125
regards,
dan carpenter
reply other threads:[~2019-03-27 8:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327075948.GA18472@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-mips@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).