linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] MIPS: SGI-IP27: rework HUB interrupts
@ 2019-03-27  7:59 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-03-27  7:59 UTC (permalink / raw)
  To: tbogendoerfer; +Cc: linux-mips

Hello Thomas Bogendoerfer,

This is a semi-automatic email about new static checker warnings.

The patch 69a07a41d908: "MIPS: SGI-IP27: rework HUB interrupts" from 
Feb 19, 2019, leads to the following Smatch complaint:

    arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq()
    warn: variable dereferenced before check 'hd' (see line 121)

arch/mips/sgi-ip27/ip27-irq.c
   117  static void shutdown_bridge_irq(struct irq_data *d)
   118  {
   119          struct hub_irq_data *hd = irq_data_get_irq_chip_data(d);
   120		struct bridge_controller *bc;
   121		int pin = hd->pin;
                          ^^^^^^^
Dereference.

   122	
   123		if (!hd)
                    ^^^
Too late.

   124			return;
   125	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-03-27  8:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-27  7:59 [bug report] MIPS: SGI-IP27: rework HUB interrupts Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).