From: Lee Jones <lee.jones@linaro.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] mfd: ioc3: Add driver for SGI IOC3 chip
Date: Tue, 25 Jun 2019 13:56:31 +0100 [thread overview]
Message-ID: <20190625125631.GH21119@dell> (raw)
In-Reply-To: <20190625090451.GA9794@alpha.franken.de>
On Tue, 25 Jun 2019, Thomas Bogendoerfer wrote:
> On Thu, Jun 13, 2019 at 07:06:31PM +0200, Thomas Bogendoerfer wrote:
> > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface.
> > It also supports connecting a SuperIO chip for serial and parallel
> > interfaces. IOC3 is used inside various SGI systemboards and add-on
> > cards with different equipped external interfaces.
> >
> > Support for ethernet and serial interfaces were implemented inside
> > the network driver. This patchset moves out the not network related
> > parts to a new MFD driver, which takes care of card detection,
> > setup of platform devices and interrupt distribution for the subdevices.
> >
> > Serial portion: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > ---
> > arch/mips/include/asm/sn/ioc3.h | 345 +++----
> > arch/mips/sgi-ip27/ip27-timer.c | 20 -
> > drivers/mfd/Kconfig | 13 +
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/ioc3.c | 683 +++++++++++++
>
> Lee,
>
> can you give me an indication, if the MFD changes are ok now
> or if I need to improve it further.
I will do, when I get to them.
My review list currently runs into the 50s.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-06-25 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:06 [PATCH v3 0/7] Use MFD framework for SGI IOC3 drivers Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 1/7] nvmem: core: add nvmem_device_find Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 2/7] MIPS: PCI: refactor ioc3 special handling Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 3/7] MIPS: PCI: use information from 1-wire PROM for IOC3 detection Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 4/7] MIPS: SGI-IP27: remove ioc3 ethernet init Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 6/7] MIPS: SGI-IP27: fix readb/writeb addressing Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 7/7] Input: add IOC3 serio driver Thomas Bogendoerfer
2019-07-01 8:19 ` Dmitry Torokhov
[not found] ` <20190613170636.6647-6-tbogendoerfer@suse.de>
2019-06-25 9:04 ` [PATCH v3 5/7] mfd: ioc3: Add driver for SGI IOC3 chip Thomas Bogendoerfer
2019-06-25 12:56 ` Lee Jones [this message]
2019-07-25 11:47 ` Lee Jones
2019-07-29 18:45 ` Thomas Bogendoerfer
2019-08-09 12:22 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625125631.GH21119@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).