From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: kernel: only use i8253 clocksource with periodic clockevent
Date: Wed, 17 Jul 2019 11:03:22 +0200 [thread overview]
Message-ID: <20190717090322.GA8585@alpha.franken.de> (raw)
In-Reply-To: <20190513114725.17823-1-tbogendoerfer@suse.de>
On Mon, May 13, 2019 at 01:47:25PM +0200, Thomas Bogendoerfer wrote:
> i8253 clocksource needs a free running timer. This could only
> be used, if i8253 clockevent is set up as periodic.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> arch/mips/kernel/i8253.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/i8253.c b/arch/mips/kernel/i8253.c
> index 5f209f111e59..df7ddd246eaa 100644
> --- a/arch/mips/kernel/i8253.c
> +++ b/arch/mips/kernel/i8253.c
> @@ -32,7 +32,8 @@ void __init setup_pit_timer(void)
>
> static int __init init_pit_clocksource(void)
> {
> - if (num_possible_cpus() > 1) /* PIT does not scale! */
> + if (num_possible_cpus() > 1 || /* PIT does not scale! */
> + !clockevent_state_periodic(&i8253_clockevent))
> return 0;
>
> return clocksource_i8253_init();
> --
> 2.13.7
Paul,
can you take it into 5.3 ? This fixes a boot ang on mips/jazz and
is the same as x86 does for quite some time.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2019-07-17 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 11:47 [PATCH] MIPS: kernel: only use i8253 clocksource with periodic clockevent Thomas Bogendoerfer
2019-07-17 9:03 ` Thomas Bogendoerfer [this message]
2019-07-17 15:58 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717090322.GA8585@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).