From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A139CC433FF for ; Mon, 12 Aug 2019 19:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FC77206C1 for ; Mon, 12 Aug 2019 19:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Go1xYdCn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726972AbfHLTwN (ORCPT ); Mon, 12 Aug 2019 15:52:13 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44684 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbfHLTwM (ORCPT ); Mon, 12 Aug 2019 15:52:12 -0400 Received: by mail-qt1-f194.google.com with SMTP id 44so73018701qtg.11 for ; Mon, 12 Aug 2019 12:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=kEkVLWwqovwyFjtoRAd3ZuRhWq4pA+S9mUWyYQC3ODQ=; b=Go1xYdCnowLCjBoQHanBZc7stvpdCA4G/sIQJnrvYOMObBB2RF6oSbhmlUQOeUImJi FjU3UE6ZPgHFVoFvHQajdt5DYsYDsfr3MtE4zVRqViB/uQewO2eXWYVzND9A6/k4syDI KiQJ6kbVnAeos66Zydq4l49v2EO55bXWiaIY8YW1yEmsocbSrMGpDqu+fWwU8vgoLsAL BjBZUWdKUw5Ietmf5bF6Q/S0JeYR6CXwsVmVc2s/Qsj4Yz5gyHXdmhwnwpT0kgnEBwjL P516qLnaRnN3sZ9sXUHu8h9MiftUXkp2Ylvq4VMfyG9py3890rhln94s9T5uukkQHTwY uSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=kEkVLWwqovwyFjtoRAd3ZuRhWq4pA+S9mUWyYQC3ODQ=; b=CaA12EHtqebpGLl+BCEV4JyI/olQGJLaBcSGS/g49/GdDjCEyTNQwwN3kn+4Igff2j C+mjkSvS8YIK2Lslry/pM/DgwErXB3DkzhaFV0Eyn7Ty/swF2eBnskISyxE4pcKrOI/I CbliJcFnUFxWiGOApilQb3aXchM3nSSeJztCksV4A6ABC3OrBniabZmJFSI00tGXVICG koAtq1tPVe/wB9k69h2dFacuprwfMlkJ4eg8dkyRJT3CtGO+j3hS0h9lHxVy+rKlq/J4 J6gmj/4S5KsAYxvcch7evvSA/ogLiC0f2L/zvWW6I5Ju7yN7AcXen6WgbXjCx4KoOGFc QVmg== X-Gm-Message-State: APjAAAWDx9yILAs9+ZtUkbeTNd/NkAZ8ShNqEnonLVJRnAInjmeSctox EYBPAfsk8KX51Nuuhpa9VSUE6g== X-Google-Smtp-Source: APXvYqy2g/f0DiyWHWOpG/JWWUORJpCznhP/S1XW87hCBQrOyaFf5OKJtY8YQ6WH8wMHkAb2ye+Nzw== X-Received: by 2002:ac8:376c:: with SMTP id p41mr11767771qtb.306.1565639531882; Mon, 12 Aug 2019 12:52:11 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id g24sm3920710qtc.38.2019.08.12.12.52.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 12:52:11 -0700 (PDT) Date: Mon, 12 Aug 2019 12:52:02 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Evgeniy Polyakov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip Message-ID: <20190812125202.46608b74@cakuba.netronome.com> In-Reply-To: <20190811093212.88635fb1a6c796a073ec71ff@suse.de> References: <20190809103235.16338-1-tbogendoerfer@suse.de> <20190809103235.16338-8-tbogendoerfer@suse.de> <20190809142222.4558691e@cakuba.netronome.com> <20190811093212.88635fb1a6c796a073ec71ff@suse.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sun, 11 Aug 2019 09:32:12 +0200, Thomas Bogendoerfer wrote: > > Also please don't use stdint types in the kernel, please try checkpatch > > to catch coding style issues. > > my patch already reduces them and checkpatch only warns about usage of printk > for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't > seem the right thing to do. As I'm splitting the conversion patch into a few > steps I could also replace the printks. Thanks for looking into it. I was referring to the use of uint32_t instead of u32. Perhaps checkpatch has to be motivated with the --strict option to point those out?