From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8499C43331 for ; Tue, 12 Nov 2019 06:30:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCA8F214E0 for ; Tue, 12 Nov 2019 06:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573540204; bh=MJTKphnDJHSZGO61ZKNpGYVhF//NXy3y8/GyhUd8yhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qIGAaria3ZQuJZIew6RQlBh6JeLM0orGptP4nvgn45RPgwKphxSDIdmYxh1r1/hIU DP+EQHlTCslatV7LbvDyblbUSPRGTRGHYQbFJLatIIkORp3wLtvqbfk1FBFlIvsIpD lZtisgqIaaFEyT/9tNBUifq3hTWtCvZ/MWaS97NY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725847AbfKLGaB (ORCPT ); Tue, 12 Nov 2019 01:30:01 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34732 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfKLGaA (ORCPT ); Tue, 12 Nov 2019 01:30:00 -0500 Received: by mail-wr1-f65.google.com with SMTP id e6so17208454wrw.1; Mon, 11 Nov 2019 22:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lAYMmo1eJk0nu5Pp/QFztO4nECppTXXyiwDmyLApAMU=; b=CmNQS9o057m02iB3aVZCvD9IKuX8qvcKJgJUgyo4KExtj2bJGSViNfCsIbt5SiuwMO vuoCblpkhQtIhImySY2l9xgcSalma2cLx/gmbDWtxOG+KeWeZqQREyCEiZtz2MaeiTEY RldTTXX6x5mGp2gTJOMJKKnH3ErtuhTGJVb/oxnV4qflBhEKc0iGhFu9X9Z6Ewwj/nv7 RJ+bk94WWdoFyERGDm1828mxsXI6cvzgXYdmifbVY3rPGuNlfG2Jz7tz9D0yBEL7amvI N9XaeSRhLvOl3rh+bmOKbDc4uYMU01us4xdrDKX0UOdp1yr6ys5I9p7y6gCnhALJgHcw WXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lAYMmo1eJk0nu5Pp/QFztO4nECppTXXyiwDmyLApAMU=; b=SuB+rEekAaU3uHUYMv0CsdK8pzV3QhZQiwcHCDzY3zz1Z7UAanvBUcGoqtJ0/Pd3n3 5VMEkbI57C0HVs00yDCEeHl9PhS0oqiFryZhGQ3fBNTSfLT/fOOZaMWu6Sr8OdnHGhN9 5c5tRQ7NTdxhsq37lhLHERvcIfTdQ7dNtvZVKB+aVwsKoQ9DAKbhltJuuaCyZWOE5eZU 3Zl3DiRM8HVujRcu9sfc8uNyALXnpunp1uGfP9BjZv4GnPxeYmqWJqGx39+8PxqYNLk6 8tIm7dz+nILDChTMsNPy9CCwbtOVj4+TGTTuBb77tW7vGZDFMEkIpavSjJkU12u/OLqY 8aNw== X-Gm-Message-State: APjAAAV3Wmoah0Y4hbrHKSAnZ3OTjgdbaYxT8z1SHVkHxYU8bA4gV1Y7 ABiT6Z44UZ9c5Wj3bRZM+so= X-Google-Smtp-Source: APXvYqwg7II6op5rkcQCA+kVGqp8JW9qmm3wOv2otknPBBGlW4hCTPNNQNQ0ueZUnows/DjxDY46Ng== X-Received: by 2002:adf:ab4c:: with SMTP id r12mr23079230wrc.3.1573540195668; Mon, 11 Nov 2019 22:29:55 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id 19sm40418570wrc.47.2019.11.11.22.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 22:29:54 -0800 (PST) Date: Tue, 12 Nov 2019 07:29:51 +0100 From: Ingo Molnar To: Anshuman Khandual Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers Message-ID: <20191112062951.GA100264@gmail.com> References: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org * Anshuman Khandual wrote: > +config DEBUG_VM_PGTABLE > + bool "Debug arch page table for semantics compliance" > + depends on MMU > + depends on DEBUG_VM > + depends on ARCH_HAS_DEBUG_VM_PGTABLE > + help > + This option provides a debug method which can be used to test > + architecture page table helper functions on various platforms in > + verifying if they comply with expected generic MM semantics. This > + will help architecture code in making sure that any changes or > + new additions of these helpers still conform to expected > + semantics of the generic MM. > + > + If unsure, say N. Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages, why not make this 'default y' to maximize testing coverage? The code size increase should be minimal, and DEBUG_VM increases size anyway. Other than that this looks good to me: Reviewed-by: Ingo Molnar Thanks, Ingo