From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0CDC49EA7 for ; Thu, 24 Jun 2021 09:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC295613F7 for ; Thu, 24 Jun 2021 09:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbhFXJpC (ORCPT ); Thu, 24 Jun 2021 05:45:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20361 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231985AbhFXJo6 (ORCPT ); Thu, 24 Jun 2021 05:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyD4vH5kMZavgg+0al23ybbW1mNcrfB3c+Wxr6kYX38=; b=Dg09Q1JBF1FT2yGNlpUzg5ZmMVjnOBAvUUr/3l3rEgNzCEWl6NxXAbpZOaTky7eftJRdKJ oLpHNwtWiHd3s5w1WybrIvw/U5xAXkcr7IYk7Yf6x3VaO8BxsZglrteqpEmK2bmTaeJjz8 YWZIaYY8hOjiyj/sr/s0Lnv4p8Zlgy0= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-rLWtG8xOMp6SyeNML5ffpg-1; Thu, 24 Jun 2021 05:42:38 -0400 X-MC-Unique: rLWtG8xOMp6SyeNML5ffpg-1 Received: by mail-ed1-f70.google.com with SMTP id r6-20020a05640216c6b0290394ed90b605so2928018edx.20 for ; Thu, 24 Jun 2021 02:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jyD4vH5kMZavgg+0al23ybbW1mNcrfB3c+Wxr6kYX38=; b=p+uXHn87YZXGOZjObQXuA/XgSX0MXMM1RPF6eR73mBnTc/3ATaz62mTwqow0NBFEUf pop3e23RVa2RZhcy78+k80MsJ7tWG3r9LE2uaI9aLiODoVyvPwG/LwA504XcMbLXmncB nCb/OJeLqrLeQptc7lJn7LaOeqrS0PWU6GYHKVQcHHD5akB5Q1uyUygPqqmNrGcKq8DJ Mm4rGn5Wen77nTbded0oacnnTpZw2m95V0tvfgCLgwI0tDVd1U9B7GiPYZp6TIer0WQk USuc8PxUM0h9xG2jYUiztVLbGL8Ez3FVDwqPu3fbkGZA5w5qyY0+6zqzREHKVWAm52jp xjqA== X-Gm-Message-State: AOAM533G4RD6mNH55nnIE9lg7xgR38CcSDPBz44T1gADGVEeNRU+HM7b /L6aIS0sG/sfZKRx8l1l3YiZAYjWAfRREk2mcDacr8gWGLbIJpbUcY9OhUGqJpZr1aZWoRsHEIB 9dgTIS/OEFQMoLkqcqrTtcA== X-Received: by 2002:a05:6402:54c:: with SMTP id i12mr5909981edx.64.1624527756951; Thu, 24 Jun 2021 02:42:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUADYaxbQu5a0ZM6V5UX0tysDgP0Lb+XMxpzsUfVTNQ4yl7MEG7UQrmtC4bLiXvUVljS3Ohw== X-Received: by 2002:a05:6402:54c:: with SMTP id i12mr5909945edx.64.1624527756727; Thu, 24 Jun 2021 02:42:36 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id jz27sm944475ejc.33.2021.06.24.02.42.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:42:35 -0700 (PDT) Subject: Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-3-stevensd@google.com> <1624524331.zsin3qejl9.astroid@bobo.none> From: Paolo Bonzini Message-ID: <201b68a7-10ea-d656-0c1e-5511b1f22674@redhat.com> Date: Thu, 24 Jun 2021 11:42:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524331.zsin3qejl9.astroid@bobo.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 24/06/21 10:52, Nicholas Piggin wrote: >> For now, wrap all calls to gfn_to_pfn functions in the new helper >> function. Callers which don't need the page struct will be updated in >> follow-up patches. > Hmm. You mean callers that do need the page will be updated? Normally > if there will be leftover users that don't need the struct page then > you would go the other way and keep the old call the same, and add a new > one (gfn_to_pfn_page) just for those that need it. Needing kvm_pfn_page_unwrap is a sign that something might be buggy, so it's a good idea to move the short name to the common case and the ugly kvm_pfn_page_unwrap(gfn_to_pfn(...)) for the weird one. In fact I'm not sure there should be any kvm_pfn_page_unwrap in the end. Paolo