From: Wang Xuerui <git@xen0n.name>
To: linux-mips@vger.kernel.org
Cc: Huacai Chen <chenhc@lemote.com>, Wang Xuerui <git@xen0n.name>
Subject: [PATCH 2/2] Revert "MIPS: asm: local: add barriers for Loongson"
Date: Mon, 3 Feb 2020 01:00:52 +0800 [thread overview]
Message-ID: <20200202170052.14012-2-git@xen0n.name> (raw)
In-Reply-To: <20200202170052.14012-1-git@xen0n.name>
From: Huacai Chen <chenhc@lemote.com>
This reverts commit 3e86460ebe2340df6a33b35a55312cc369bdcbd0.
Local ops don't need SYNCs before LL because there is only one writer,
the erratum is not triggered.
The LLSCCHK violations are made not to fail the build in the previous
patch so just revert the additions.
[git@xen0n.name: Massaged commit message.]
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Wang Xuerui <git@xen0n.name>
---
arch/mips/include/asm/local.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/mips/include/asm/local.h b/arch/mips/include/asm/local.h
index fef0fda8f82f..02783e141c32 100644
--- a/arch/mips/include/asm/local.h
+++ b/arch/mips/include/asm/local.h
@@ -37,7 +37,6 @@ static __inline__ long local_add_return(long i, local_t * l)
__asm__ __volatile__(
" .set push \n"
" .set arch=r4000 \n"
- __SYNC(full, loongson3_war) " \n"
"1:" __LL "%1, %2 # local_add_return \n"
" addu %0, %1, %3 \n"
__SC "%0, %2 \n"
@@ -53,7 +52,6 @@ static __inline__ long local_add_return(long i, local_t * l)
__asm__ __volatile__(
" .set push \n"
" .set "MIPS_ISA_ARCH_LEVEL" \n"
- __SYNC(full, loongson3_war) " \n"
"1:" __LL "%1, %2 # local_add_return \n"
" addu %0, %1, %3 \n"
__SC "%0, %2 \n"
@@ -86,7 +84,6 @@ static __inline__ long local_sub_return(long i, local_t * l)
__asm__ __volatile__(
" .set push \n"
" .set arch=r4000 \n"
- __SYNC(full, loongson3_war) " \n"
"1:" __LL "%1, %2 # local_sub_return \n"
" subu %0, %1, %3 \n"
__SC "%0, %2 \n"
@@ -102,7 +99,6 @@ static __inline__ long local_sub_return(long i, local_t * l)
__asm__ __volatile__(
" .set push \n"
" .set "MIPS_ISA_ARCH_LEVEL" \n"
- __SYNC(full, loongson3_war) " \n"
"1:" __LL "%1, %2 # local_sub_return \n"
" subu %0, %1, %3 \n"
__SC "%0, %2 \n"
--
2.21.0
next prev parent reply other threads:[~2020-02-03 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 17:00 [PATCH 1/2] MIPS: loongson3-llsc-check: Downgrade failures to notices Wang Xuerui
2020-02-02 17:00 ` Wang Xuerui [this message]
2020-02-10 19:24 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200202170052.14012-2-git@xen0n.name \
--to=git@xen0n.name \
--cc=chenhc@lemote.com \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox