From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A0BC34047 for ; Wed, 19 Feb 2020 15:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4165524670 for ; Wed, 19 Feb 2020 15:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgBSPSP (ORCPT ); Wed, 19 Feb 2020 10:18:15 -0500 Received: from mga04.intel.com ([192.55.52.120]:22682 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbgBSPSP (ORCPT ); Wed, 19 Feb 2020 10:18:15 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2020 07:18:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,459,1574150400"; d="scan'208";a="235919620" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by orsmga003.jf.intel.com with ESMTP; 19 Feb 2020 07:18:14 -0800 Date: Wed, 19 Feb 2020 07:18:14 -0800 From: Sean Christopherson To: Sergei Shtylyov Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Peter Xu , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v6 21/22] KVM: x86/mmu: Use ranged-based TLB flush for dirty log memslot flush Message-ID: <20200219151814.GC15888@linux.intel.com> References: <20200218210736.16432-1-sean.j.christopherson@intel.com> <20200218210736.16432-22-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Feb 19, 2020 at 12:22:58PM +0300, Sergei Shtylyov wrote: > Hello! > > On 19.02.2020 0:07, Sean Christopherson wrote: > > >Use the with_address() variant to when performing a TLB flush for a > ^^ is it really needed here? Doh, thanks. The subject also has a typo, it should be "range-based", not "ranged-based". > >specific memslot via kvm_arch_flush_remote_tlbs_memslot(), i.e. when > >flushing after clearing dirty bits during KVM_{GET,CLEAR}_DIRTY_LOG. > >This aligns all dirty log memslot-specific TLB flushes to use the > >with_address() variant and paves the way for consolidating the relevant > >code. > > > >Note, moving to the with_address() variant only affects functionality > >when running as a HyperV guest. > > > >Cc: Vitaly Kuznetsov > >Signed-off-by: Sean Christopherson > [...] > > MBR, Sergei