* [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 19:20 ` Thomas Bogendoerfer [not found] ` <20200311153000.GP12561@hirez.programming.kicks-ass.net> 2020-03-11 4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches 2020-03-11 4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches 2 siblings, 2 replies; 7+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: Peter Zijlstra, Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim Cc: Thomas Bogendoerfer, Thomas Gleixner, Borislav Petkov, H. Peter Anvin, x86, linux-kernel, linux-mips Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- arch/mips/kernel/perf_event_mipsxx.c | 6 +++--- arch/x86/events/intel/core.c | 7 +++---- arch/x86/events/intel/lbr.c | 2 +- kernel/events/core.c | 3 +-- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_event_mipsxx.c index 128fc9..484948 100644 --- a/arch/mips/kernel/perf_event_mipsxx.c +++ b/arch/mips/kernel/perf_event_mipsxx.c @@ -790,15 +790,15 @@ static void reset_counters(void *arg) case 4: mipsxx_pmu_write_control(3, 0); mipspmu.write_counter(3, 0); - /* fall through */ + fallthrough; case 3: mipsxx_pmu_write_control(2, 0); mipspmu.write_counter(2, 0); - /* fall through */ + fallthrough; case 2: mipsxx_pmu_write_control(1, 0); mipspmu.write_counter(1, 0); - /* fall through */ + fallthrough; case 1: mipsxx_pmu_write_control(0, 0); mipspmu.write_counter(0, 0); diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index 332954..8cd3bb 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -4637,8 +4637,7 @@ __init int intel_pmu_init(void) case INTEL_FAM6_CORE2_MEROM: x86_add_quirk(intel_clovertown_quirk); - /* fall through */ - + fallthrough; case INTEL_FAM6_CORE2_MEROM_L: case INTEL_FAM6_CORE2_PENRYN: case INTEL_FAM6_CORE2_DUNNINGTON: @@ -5017,7 +5016,7 @@ __init int intel_pmu_init(void) case INTEL_FAM6_SKYLAKE_X: pmem = true; - /* fall through */ + fallthrough; case INTEL_FAM6_SKYLAKE_L: case INTEL_FAM6_SKYLAKE: case INTEL_FAM6_KABYLAKE_L: @@ -5069,7 +5068,7 @@ __init int intel_pmu_init(void) case INTEL_FAM6_ICELAKE_X: case INTEL_FAM6_ICELAKE_D: pmem = true; - /* fall through */ + fallthrough; case INTEL_FAM6_ICELAKE_L: case INTEL_FAM6_ICELAKE: case INTEL_FAM6_TIGERLAKE_L: diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c index 65113b1..2e2c6fb 100644 --- a/arch/x86/events/intel/lbr.c +++ b/arch/x86/events/intel/lbr.c @@ -967,7 +967,7 @@ static int branch_type(unsigned long from, unsigned long to, int abort) ret = X86_BR_ZERO_CALL; break; } - /* fall through */ + fallthrough; case 0x9a: /* call far absolute */ ret = X86_BR_CALL; break; diff --git a/kernel/events/core.c b/kernel/events/core.c index 6a47c3..7a8ed4d5 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9762,8 +9762,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr, case IF_SRC_KERNELADDR: case IF_SRC_KERNEL: kernel = 1; - /* fall through */ - + fallthrough; case IF_SRC_FILEADDR: case IF_SRC_FILE: if (state != IF_STATE_SOURCE) -- 2.24.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; Joe Perches @ 2020-03-11 19:20 ` Thomas Bogendoerfer [not found] ` <20200311153000.GP12561@hirez.programming.kicks-ass.net> 1 sibling, 0 replies; 7+ messages in thread From: Thomas Bogendoerfer @ 2020-03-11 19:20 UTC (permalink / raw) To: Joe Perches Cc: Peter Zijlstra, Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Thomas Gleixner, Borislav Petkov, H. Peter Anvin, x86, linux-kernel, linux-mips On Tue, Mar 10, 2020 at 09:51:18PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20200311153000.GP12561@hirez.programming.kicks-ass.net>]
* Re: [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; [not found] ` <20200311153000.GP12561@hirez.programming.kicks-ass.net> @ 2020-03-12 6:15 ` Joe Perches 0 siblings, 0 replies; 7+ messages in thread From: Joe Perches @ 2020-03-12 6:15 UTC (permalink / raw) To: Peter Zijlstra Cc: Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Thomas Bogendoerfer, Thomas Gleixner, Borislav Petkov, H. Peter Anvin, x86, linux-kernel, linux-mips On Wed, 2020-03-11 at 16:30 +0100, Peter Zijlstra wrote: > On Tue, Mar 10, 2020 at 09:51:18PM -0700, Joe Perches wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches <joe@perches.com> > > The subject can use a little less screaming, but the actual patch is > fine. Patch subject come from the MAINTAINERS subsystem/section heading because I don't see a better way to script the patch subject that is more effective. Using something like: $ cat get_patch_subject_prefix.bash #!/bin/bash git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \ cut -f1 -d":" | \ sort | uniq -c | sort -rn | head -1 | \ sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//' $ Does well for some sets of files, less well for others. For instance: $ ./get_patch_subject_prefix.bash drivers/net/ethernet/intel/ ice which is just one of 10 or so subsystems of intel/... And there's no way I'm going to individually edit ~500 patches for every specific maintainer's preference. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> 2020-03-11 4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; Joe Perches @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 19:19 ` Thomas Bogendoerfer 2020-03-11 4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches 2 siblings, 1 reply; 7+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: Maciej W. Rozycki; +Cc: Thomas Bogendoerfer, linux-mips, linux-kernel Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- arch/mips/dec/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/dec/tc.c b/arch/mips/dec/tc.c index 732027c..dba583 100644 --- a/arch/mips/dec/tc.c +++ b/arch/mips/dec/tc.c @@ -52,7 +52,7 @@ int __init tc_bus_get_info(struct tc_bus *tbus) case MACH_DS5900: tbus->ext_slot_base = 0x20000000; tbus->ext_slot_size = 0x20000000; - /* fall through */ + fallthrough; case MACH_DS5000_1XX: tbus->num_tcslots = 3; break; -- 2.24.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches @ 2020-03-11 19:19 ` Thomas Bogendoerfer 0 siblings, 0 replies; 7+ messages in thread From: Thomas Bogendoerfer @ 2020-03-11 19:19 UTC (permalink / raw) To: Joe Perches; +Cc: Maciej W. Rozycki, linux-mips, linux-kernel On Tue, Mar 10, 2020 at 09:51:28PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/mips/dec/tc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/dec/tc.c b/arch/mips/dec/tc.c > index 732027c..dba583 100644 > --- a/arch/mips/dec/tc.c > +++ b/arch/mips/dec/tc.c > @@ -52,7 +52,7 @@ int __init tc_bus_get_info(struct tc_bus *tbus) > case MACH_DS5900: > tbus->ext_slot_base = 0x20000000; > tbus->ext_slot_size = 0x20000000; > - /* fall through */ > + fallthrough; > case MACH_DS5000_1XX: > tbus->num_tcslots = 3; > break; Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> 2020-03-11 4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; Joe Perches 2020-03-11 4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 19:20 ` Thomas Bogendoerfer 2 siblings, 1 reply; 7+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: linux-kernel; +Cc: Thomas Bogendoerfer, linux-mips, kvm Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- arch/mips/kvm/emulate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c index 754094..8c80333 100644 --- a/arch/mips/kvm/emulate.c +++ b/arch/mips/kvm/emulate.c @@ -64,7 +64,7 @@ static int kvm_compute_return_epc(struct kvm_vcpu *vcpu, unsigned long instpc, switch (insn.r_format.func) { case jalr_op: arch->gprs[insn.r_format.rd] = epc + 8; - /* Fall through */ + fallthrough; case jr_op: nextpc = arch->gprs[insn.r_format.rs]; break; @@ -140,7 +140,7 @@ static int kvm_compute_return_epc(struct kvm_vcpu *vcpu, unsigned long instpc, /* These are unconditional and in j_format. */ case jal_op: arch->gprs[31] = instpc + 8; - /* fall through */ + fallthrough; case j_op: epc += 4; epc >>= 28; @@ -1724,14 +1724,14 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst, case lhu_op: vcpu->mmio_needed = 1; /* unsigned */ - /* fall through */ + fallthrough; case lh_op: run->mmio.len = 2; break; case lbu_op: vcpu->mmio_needed = 1; /* unsigned */ - /* fall through */ + fallthrough; case lb_op: run->mmio.len = 1; break; -- 2.24.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches @ 2020-03-11 19:20 ` Thomas Bogendoerfer 0 siblings, 0 replies; 7+ messages in thread From: Thomas Bogendoerfer @ 2020-03-11 19:20 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, linux-mips, kvm On Tue, Mar 10, 2020 at 09:51:29PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/mips/kvm/emulate.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-12 6:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; Joe Perches
2020-03-11 19:20 ` Thomas Bogendoerfer
[not found] ` <20200311153000.GP12561@hirez.programming.kicks-ass.net>
2020-03-12 6:15 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches
2020-03-11 19:19 ` Thomas Bogendoerfer
2020-03-11 4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches
2020-03-11 19:20 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).