From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DEA9C0044D for ; Mon, 16 Mar 2020 10:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1923E2071C for ; Mon, 16 Mar 2020 10:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730582AbgCPK0c (ORCPT ); Mon, 16 Mar 2020 06:26:32 -0400 Received: from foss.arm.com ([217.140.110.172]:45454 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730574AbgCPK0c (ORCPT ); Mon, 16 Mar 2020 06:26:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D936F1FB; Mon, 16 Mar 2020 03:26:31 -0700 (PDT) Received: from mbp (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD0423F534; Mon, 16 Mar 2020 03:26:28 -0700 (PDT) Date: Mon, 16 Mar 2020 10:26:22 +0000 From: Catalin Marinas To: Mark Rutland Cc: Vincenzo Frascino , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers , Marc Zyngier , Will Deacon Subject: Re: [PATCH v3 18/26] arm64: Introduce asm/vdso/processor.h Message-ID: <20200316102621.GC3005@mbp> References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-19-vincenzo.frascino@arm.com> <20200315182950.GB32205@mbp> <20200316102214.GA5746@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316102214.GA5746@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Mar 16, 2020 at 10:22:15AM +0000, Mark Rutland wrote: > On Mon, Mar 16, 2020 at 09:42:32AM +0000, Vincenzo Frascino wrote: > > On 3/15/20 6:30 PM, Catalin Marinas wrote: > > > On Fri, Mar 13, 2020 at 03:43:37PM +0000, Vincenzo Frascino wrote: > > >> --- /dev/null > > >> +++ b/arch/arm64/include/asm/vdso/processor.h > > >> @@ -0,0 +1,31 @@ > > >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > >> +/* > > >> + * Copyright (C) 2020 ARM Ltd. > > >> + */ > > >> +#ifndef __ASM_VDSO_PROCESSOR_H > > >> +#define __ASM_VDSO_PROCESSOR_H > > >> + > > >> +#ifndef __ASSEMBLY__ > > >> + > > >> +#include > > >> + > > >> +#ifdef CONFIG_COMPAT > > >> +#if defined(CONFIG_ARM64_64K_PAGES) && defined(CONFIG_KUSER_HELPERS) > > >> +/* > > >> + * With CONFIG_ARM64_64K_PAGES enabled, the last page is occupied > > >> + * by the compat vectors page. > > >> + */ > > >> +#define TASK_SIZE_32 UL(0x100000000) > > >> +#else > > >> +#define TASK_SIZE_32 (UL(0x100000000) - PAGE_SIZE) > > >> +#endif /* CONFIG_ARM64_64K_PAGES */ > > >> +#endif /* CONFIG_COMPAT */ > > > > > > Just curious, what's TASK_SIZE_32 used for in the vDSO code? You don't > > > seem to move TASK_SIZE. > > > > > > > I tried to fine grain the headers as much as I could in order to avoid > > unneeded/unwanted inclusions: > > * TASK_SIZE_32 is used to verify ABI consistency on vdso32 (please refer to > > arch/arm64/kernel/vdso32/vgettimeofday.c). > > * TASK_SIZE is not required by the vdso library hence it is not present in > > these headers. > > It would be worth noting the former point in the commit message, since > it can be surprising. > > I also think it's worth keeping the definitions together if that's easy, > as it makes it easier to navigate the codebase, even if TASK_SIZE isn't > necessary for the VDSO itself. It won't work as TASK_SIZE requires (on arm64) test_thread_flag() which can't be made available to the vDSO. -- Catalin