From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
"BCM Kernel Feedback" <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment
Date: Tue, 17 Mar 2020 14:32:20 -0500 [thread overview]
Message-ID: <20200317193220.GB708@MININT-65B7IF6> (raw)
In-Reply-To: <20200317095037.22313-1-rayagonda.kokatanur@broadcom.com>
On 2020-03-17 15:20:37, Rayagonda Kokatanur wrote:
> Remove unused variable assignment.
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Tyler
> ---
> Changes from v1:
> - Address code review comment from Sergei Shtylyov,
> Correct the commit message.
>
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>
> while (rbytes) {
> - nbytes = rbytes;
> -
> nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>
> /* Fill additional invoke cmd params */
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-17 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:50 [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment Rayagonda Kokatanur
2020-03-17 19:32 ` Tyler Hicks [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-23 7:02 Rayagonda Kokatanur
2020-03-23 7:07 Rayagonda Kokatanur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317193220.GB708@MININT-65B7IF6 \
--to=tyhicks@linux.microsoft.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).