MIPS: ralink: mt7621: introduce 'soc_device' initialization, compile issue

MIPS: ralink: mt7621: introduce 'soc_device' initialization, compile issue

[René van Dorst]

Hi Sergio,

I am hitting this issue with the lastest linux-next:

/home/rene/dev/openwrt/staging_dir/toolchain-mipsel_24kc_gcc-8.3.0_musl/bin/mipsel-openwrt-linux-ld: arch/mips/ralink/mt7621.o: in function  
`soc_dev_init':
/home/rene/dev/net-next/arch/mips/ralink/mt7621.c:185: undefined  
reference to `soc_device_register'
make: *** [Makefile:1086: vmlinux] Error 1

Are you also experiencing this issue?

I don't see any other compiler issue.

Greats,

René

Re: MIPS: ralink: mt7621: introduce 'soc_device' initialization, compile issue

[Sergio Paracuellos]

Hi René,

On Fri, Mar 27, 2020 at 4:26 PM René van Dorst <opensource@vdorst.com> wrote:
>
> Hi Sergio,
>
> I am hitting this issue with the lastest linux-next:
>
> /home/rene/dev/openwrt/staging_dir/toolchain-mipsel_24kc_gcc-8.3.0_musl/bin/mipsel-openwrt-linux-ld: arch/mips/ralink/mt7621.o: in function
> `soc_dev_init':
> /home/rene/dev/net-next/arch/mips/ralink/mt7621.c:185: undefined
> reference to `soc_device_register'
> make: *** [Makefile:1086: vmlinux] Error 1
>
> Are you also experiencing this issue?
>

No it compiles clean for me with the last linux-next. The function
'soc_device_register' is implemented in drivers/base/soc.c which is
included for compilation with
CONFIG_SOC_BUS. Looks like kernel is not compiling soc.c for any reason.

> I don't see any other compiler issue.
>
> Greats,
>
> René

Best regards,
    Sergio Paracuellos
>
>
>

Re: MIPS: ralink: mt7621: introduce 'soc_device' initialization, compile issue

[Thomas Bogendoerfer]

On Sat, Mar 28, 2020 at 07:49:25AM +0100, Sergio Paracuellos wrote:
> No it compiles clean for me with the last linux-next. The function
> 'soc_device_register' is implemented in drivers/base/soc.c which is
> included for compilation with
> CONFIG_SOC_BUS. Looks like kernel is not compiling soc.c for any reason.

tom me it looks like you never tested, that your patch works.
With SMP selected the new code doesn't even get compiled in.
With a UP config, Rene's link error shows up.

I've sent a patch fixing this.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: MIPS: ralink: mt7621: introduce 'soc_device' initialization, compile issue

[Sergio Paracuellos]

Hi Thomas,

On Sat, Mar 28, 2020 at 11:30 AM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Sat, Mar 28, 2020 at 07:49:25AM +0100, Sergio Paracuellos wrote:
> > No it compiles clean for me with the last linux-next. The function
> > 'soc_device_register' is implemented in drivers/base/soc.c which is
> > included for compilation with
> > CONFIG_SOC_BUS. Looks like kernel is not compiling soc.c for any reason.
>
> tom me it looks like you never tested, that your patch works.
> With SMP selected the new code doesn't even get compiled in.
> With a UP config, Rene's link error shows up.
>
> I've sent a patch fixing this.

Thanks for this and sorry for inconvenience.

My changes were compile tested and I ran the resulted kernel in a
gnubee pc1 without issues. More than that I did not test anything
else.
I have just recompile the linux-next tree and the kernel linked for me:

$ git log
commit 975f7a88c64dfdfde014530730ba7a6f3141f773 (tag: next-20200327,
origin/master, origin/HEAD)
$ ls -l ./arch/mips/ralink/mt7621.o
-rw-rw-r-- 1 sergio sergio 28616 mar 28 12:14 ./arch/mips/ralink/mt7621.o
$ ls -l vmlinux
-rwxrwxr-x 1 sergio sergio 42324732 mar 28 12:19 vmlinux

I wonder why I am not seeing the error pointed out here...

I am using:

$ /opt/cross/bin/mipsel-unknown-linux-gnu-gcc --version
mipsel-unknown-linux-gnu-gcc (GCC) 7.2.0

>
> Thomas.
>

Thanks,
    Sergio Paracuellos
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]