From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: YunQiang Su <wzssyqa@gmail.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips <linux-mips@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: Limit check_bugs32() under CONFIG_32BIT
Date: Thu, 9 Apr 2020 15:09:23 +0800 [thread overview]
Message-ID: <20200409150923.5b224361@flygoat-x1e> (raw)
In-Reply-To: <CAKcpw6XywbOs-rh5ko0uz9vLz9nkgrJ0LiRTSkQQaU9dZbg7oQ@mail.gmail.com>
On Thu, 9 Apr 2020 12:43:28 +0800
YunQiang Su <wzssyqa@gmail.com> wrote:
> Tiezhu Yang <yangtiezhu@loongson.cn> 于2020年4月9日周四
> 上午11:10写道：
> >
> > There is no need to build and call check_bugs32() under
> > CONFIG_64BIT, just limit it under CONFIG_32BIT.
>
> Since 32bit is subset of 64bit, and due to the code, I think that the
> initial purpose
> of check_bugs32() is also willing to run even with CONFIG_64BIT.
>
> For example, if we have a CPU which is 64bit, and work well on 64bit
> mode, while has a bug only on 32bit mode, check_bugs32 should be used
> here.
>
> Loongson's 3A 1000 is the example, I cannot support FP32 mode well.
In this case bugs32 only contains a workaround for MIPS34K, which is a
MIPS32 processor. It's safe to do so.
But my suggestion is if you're going to clean-up bugs and workarounds
you'd better establish a file for silicon bugs and provide Kconfig
options to enable & disable them. Manage bug dependencies by Kconfig
will be easier.
Thanks.
--
Jiaxun Yang
next prev parent reply other threads:[~2020-04-09 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 3:10 [PATCH] MIPS: Limit check_bugs32() under CONFIG_32BIT Tiezhu Yang
2020-04-09 4:43 ` YunQiang Su
2020-04-09 7:09 ` Jiaxun Yang [this message]
2020-04-09 15:07 ` Maciej W. Rozycki
2020-04-09 15:47 ` Jiaxun Yang
2020-04-09 16:15 ` Maciej W. Rozycki
2020-04-09 20:48 ` Jiaxun Yang
2020-04-11 7:37 ` YunQiang Su
2020-04-11 10:38 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409150923.5b224361@flygoat-x1e \
--to=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
--cc=wzssyqa@gmail.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox