Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Huacai Chen <chenhc@lemote.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
	Zhangjin Wu <wuzhangjin@gmail.com>,
	Huacai Chen <chenhuacai@gmail.com>,
	Pei Huang <huangpei@loongson.cn>,
	Shuangshuang Zhang <zhangshuangshuang@loongson.cn>
Subject: Re: [PATCH] MIPS: Loongson-3: Add some unaligned instructions emulation
Date: Thu, 9 Apr 2020 17:44:17 +0800	[thread overview]
Message-ID: <20200409174417.6e83e70e@flygoat-x1e> (raw)
In-Reply-To: <1586425675-31860-1-git-send-email-chenhc@lemote.com>

On Thu,  9 Apr 2020 17:47:55 +0800
Huacai Chen <chenhc@lemote.com> wrote:

> 1, Add unaligned gslq, gssq, gslqc1, gssqc1 emulation;
> 2, Add unaligned gsl{h, w, d}x, gss{h, w, d}x emulation;
> 3, Add unaligned gslwxc1, gsswxc1, gsldxc1, gssdxc1 emulation.

Probably you should split your changes into two patches?
The first patch moves load & store helpers to the header and the second
one adds emulation in exception handler.

Thanks.

> 
> Signed-off-by: Pei Huang <huangpei@loongson.cn>
> Signed-off-by: Shuangshuang Zhang <zhangshuangshuang@loongson.cn>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  arch/mips/include/asm/fpu_emulator.h |   2 -
>  arch/mips/include/asm/inst.h         | 773
> ++++++++++++++++++++++++++++++++++ arch/mips/include/uapi/asm/inst.h
>   |  26 ++ arch/mips/kernel/unaligned.c         | 775
> ----------------------------------- arch/mips/loongson64/cop2-ex.c
>    | 274 ++++++++++++- 5 files changed, 1072 insertions(+), 778
> deletions(-)
> 

--
Jiaxun Yang

      reply	other threads:[~2020-04-09  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  9:47 [PATCH] MIPS: Loongson-3: Add some unaligned instructions emulation Huacai Chen
2020-04-09  9:44 ` Jiaxun Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409174417.6e83e70e@flygoat-x1e \
    --to=jiaxun.yang@flygoat.com \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=huangpei@loongson.cn \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=wuzhangjin@gmail.com \
    --cc=zhangfx@lemote.com \
    --cc=zhangshuangshuang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox