From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CCFC2BA19 for ; Tue, 14 Apr 2020 08:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61A0E206D5 for ; Tue, 14 Apr 2020 08:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=flygoat.com header.i=jiaxun.yang@flygoat.com header.b="dUMOEe2t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436968AbgDNIiV (ORCPT ); Tue, 14 Apr 2020 04:38:21 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17822 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436965AbgDNIiT (ORCPT ); Tue, 14 Apr 2020 04:38:19 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1586853318; cv=none; d=zoho.com.cn; s=zohoarc; b=X69YMJgD4rV2vo8a/7oARBHBEmxcrrECiE/OTTv6kBGFrETLPTRc0861mbMUwUCrTGBS36MyyBEsJIIZbksTJ/FQuCHL1zy2ODjt03CaaHwvycxUc9ll4Fz99UecVVkS2F8jl6QcEQcrP9S9NUBKUVFkTnkGbQrzRg2TlmxyaMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1586853318; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=84CrosZczlRKs4cv9GnHtu9KBHymfYmBVO3bAUZ/y6w=; b=CoYq2vjxJaEW+p0M4Lsbbahs37GRWw4yRPoaYhzcW5PLKVelw3TsNo5PpiXn6bLbukLLMxIGb8nZMJscwaV46TIMvhO1QVUI1KAvvx8v1kjKG8UxqnLx+x6a4zOsjRLgHKjjC4tHAEwtm31ppwXEBLAPI7Mh6eYoUP+031ORxu4= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=flygoat.com; spf=pass smtp.mailfrom=jiaxun.yang@flygoat.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1586853318; s=mail; d=flygoat.com; i=jiaxun.yang@flygoat.com; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=84CrosZczlRKs4cv9GnHtu9KBHymfYmBVO3bAUZ/y6w=; b=dUMOEe2tgenEpWpWEB8vbLn1NBqOpK/XUtm1E6UFZohY9nHzmqlco79iN+9dw8wP uDCfdQXCwPSr58TCvYu0aVswfmnZIQS/I5rGh/+5iaXPEORCKYapvGzZ78pQpkAo2ol VuCI8ufTEp3yUUH1iG2It/baKThv55NNZ8rR2DJo= Received: from localhost (122.235.212.87 [122.235.212.87]) by mx.zoho.com.cn with SMTPS id 15868533144941003.2196604203903; Tue, 14 Apr 2020 16:35:14 +0800 (CST) Date: Tue, 14 Apr 2020 16:35:14 +0800 From: Jiaxun Yang To: Sudeep Holla Cc: linux-mips@vger.kernel.org, dietmar.eggemann@arm.com, Thomas Bogendoerfer , Huacai Chen , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Florian Fainelli , Robert Richter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Daniel Lezcano , Thomas Gleixner , Jason Cooper , Marc Zyngier , Paul Burton , Allison Randal , Enrico Weigelt , Kate Stewart , Vladimir Kondratiev , Alexios Zavras , Paul Cercueil , Zhou Yanjie , " =?GB18030?B?1tzn/L3c?= (Zhou Yanjie)" , YunQiang Su , Arnd Bergmann , Serge Semin , Matt Redfearn , Richard Fontana , Steve Winslow , afzal mohammed , Peter Xu , Kamal Dasu , Oleksij Rempel , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, oprofile-list@lists.sf.net, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 04/11] arch_topology: Reset all cpus in reset_cpu_topology Message-ID: <20200414163514.00000100@flygoat.com> In-Reply-To: <20200414082734.GC6459@bogus> References: <20200412032123.3896114-1-jiaxun.yang@flygoat.com> <20200412032123.3896114-5-jiaxun.yang@flygoat.com> <20200414082734.GC6459@bogus> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ZohoCNMailClient: External Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 14 Apr 2020 09:27:34 +0100 Sudeep Holla wrote: > On Sun, Apr 12, 2020 at 11:20:34AM +0800, Jiaxun Yang wrote: > > For MIPS platform, when topology isn't probed by DeviceTree, > > possible_cpu might be empty when calling init_cpu_topology, > > that may result cpu_topology not fully reseted for all CPUs. > > So here we can reset all cpus instead of possible cpus. > > > > As I have told before adjust and make it default before this function > gets called. Hi, That's really impossible under current MIPS code structure. Another option would be prefill possible_cpu with all_cpu_mask before calling topology_init, but that would make the code unnecessarily complex. Here simply reset the whole array won't cause any regression. Thanks. > -- Jiaxun Yang