From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62248C2BB85 for ; Wed, 15 Apr 2020 16:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E0A4208E4 for ; Wed, 15 Apr 2020 16:21:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hv+JBIGA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415634AbgDOQVV (ORCPT ); Wed, 15 Apr 2020 12:21:21 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55131 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415581AbgDOQVS (ORCPT ); Wed, 15 Apr 2020 12:21:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586967677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sd5eA/N/NI5n7N98BdtAvkb6ngdNDSTXR+h4Z3gbW68=; b=Hv+JBIGAlbbtEtn+eXc8GZepHt9ZYk1tUes4SDdNg9cw9A+13ouJSlsvj0KjKPM8+9gw7V zIObJlxCM1zxViljHebLAdWBwY9sQeTf40AoHfVonDiq/Siiv21dobVbGmLbZyuxmaXJ7I HblPtlAHVIdOwqc/e3x1JDufWK4Txho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-wrQvUDtbM8mVEqqfRLVCsg-1; Wed, 15 Apr 2020 12:21:15 -0400 X-MC-Unique: wrQvUDtbM8mVEqqfRLVCsg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90C09107B267; Wed, 15 Apr 2020 16:21:12 +0000 (UTC) Received: from gondolin (ovpn-113-55.ams2.redhat.com [10.36.113.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 017ACA63D6; Wed, 15 Apr 2020 16:21:02 +0000 (UTC) Date: Wed, 15 Apr 2020 18:20:37 +0200 From: Cornelia Huck To: Emanuele Giuseppe Esposito Cc: kvm@vger.kernel.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place Message-ID: <20200415182037.521a92b2.cohuck@redhat.com> In-Reply-To: <20200414155625.20559-1-eesposit@redhat.com> References: <20200414155625.20559-1-eesposit@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 14 Apr 2020 17:56:25 +0200 Emanuele Giuseppe Esposito wrote: > The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple > files, each used by a different architecure to initialize the debugfs > entries for statistics. Since they all have the same purpose, they can be > unified in a single common definition in include/linux/kvm_host.h > > Signed-off-by: Emanuele Giuseppe Esposito > --- > arch/arm64/kvm/guest.c | 23 ++--- > arch/mips/kvm/mips.c | 61 ++++++------ > arch/powerpc/kvm/book3s.c | 61 ++++++------ > arch/powerpc/kvm/booke.c | 41 ++++---- > arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++------------------- > arch/x86/kvm/x86.c | 80 +++++++-------- > include/linux/kvm_host.h | 5 + > 7 files changed, 231 insertions(+), 243 deletions(-) Adds a bit of churn, but the end result does look nicer. Looks sane, but did not review in detail. Acked-by: Cornelia Huck