Re: [PATCH] Add missing ifdefs to SGI Platform files for IP22, IP32

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Thu, Apr 16, 2020 at 07:18:35PM -0400, Joshua Kinard wrote:
> On 4/16/2020 12:30, Thomas Bogendoerfer wrote:
> > On Mon, Mar 30, 2020 at 11:25:52PM -0400, Joshua Kinard wrote:
> >> The attached patch fixes the SGI-specific Platform files to only be
> >> included when their specific platform is actually built.  Both the
> >> IP27 and IP30 Platform files already have such ifdefs in place.  This
> >> patch adds the same to the IP22 and IP32 Platform files.
> > 
> > looking at all other Platform files, I fail to see why this is needed.
> > It looks like removing the ifdefs from IP27 and IP30 is the way to
> > go. What do I miss here ?
> > 
> > Thomas.
> 
> I ran into an issue long ago where an IP32 kernel tried dragging in some of
> the directives in IP30 because of the missing ifdef checks, thus causing the
> build to fail.

do you still see this problem ? If yes, I'd like to understand why first.
If no, what about dropping this patch ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]