From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Huacai Chen <chenhc@lemote.com>
Cc: linux-mips@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] MIPS: Rename the "Fill" cache ops to avoid build failure
Date: Sun, 26 Apr 2020 15:45:04 +0200 [thread overview]
Message-ID: <20200426134504.GA8299@alpha.franken.de> (raw)
In-Reply-To: <1587899392-10579-1-git-send-email-chenhc@lemote.com>
On Sun, Apr 26, 2020 at 07:09:52PM +0800, Huacai Chen wrote:
> MIPS define a "Fill" macro as a cache operation in cacheops.h, this
> will cause build failure under some special configurations because in
> seq_file.c there is a "Fill" label. To avoid this failure we rename the
> "Fill" macro to "Fill_I" which has the same coding style as other cache
> operations in cacheops.h (we think renaming the "Fill" macro is more
> reasonable than renaming the "Fill" label).
>
> Callers of "Fill" macro is also updated.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> arch/mips/include/asm/cacheops.h | 2 +-
> arch/mips/mm/c-r4k.c | 2 +-
> arch/mips/pmcs-msp71xx/msp_setup.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2020-04-26 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 11:09 [PATCH] MIPS: Rename the "Fill" cache ops to avoid build failure Huacai Chen
2020-04-26 13:45 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200426134504.GA8299@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).