From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489D2C55194 for ; Sun, 26 Apr 2020 13:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 332DC20700 for ; Sun, 26 Apr 2020 13:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgDZNqz (ORCPT ); Sun, 26 Apr 2020 09:46:55 -0400 Received: from elvis.franken.de ([193.175.24.41]:55774 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgDZNqy (ORCPT ); Sun, 26 Apr 2020 09:46:54 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jShcS-0000jA-00; Sun, 26 Apr 2020 15:46:52 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 28010C02FB; Sun, 26 Apr 2020 15:45:04 +0200 (CEST) Date: Sun, 26 Apr 2020 15:45:04 +0200 From: Thomas Bogendoerfer To: Huacai Chen Cc: linux-mips@vger.kernel.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Jiaxun Yang Subject: Re: [PATCH] MIPS: Rename the "Fill" cache ops to avoid build failure Message-ID: <20200426134504.GA8299@alpha.franken.de> References: <1587899392-10579-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587899392-10579-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sun, Apr 26, 2020 at 07:09:52PM +0800, Huacai Chen wrote: > MIPS define a "Fill" macro as a cache operation in cacheops.h, this > will cause build failure under some special configurations because in > seq_file.c there is a "Fill" label. To avoid this failure we rename the > "Fill" macro to "Fill_I" which has the same coding style as other cache > operations in cacheops.h (we think renaming the "Fill" macro is more > reasonable than renaming the "Fill" label). > > Callers of "Fill" macro is also updated. > > Signed-off-by: Huacai Chen > --- > arch/mips/include/asm/cacheops.h | 2 +- > arch/mips/mm/c-r4k.c | 2 +- > arch/mips/pmcs-msp71xx/msp_setup.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]