linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
	richard@nod.at, vigneshr@ti.com, arnd@arndb.de,
	brendanhiggins@google.com, tglx@linutronix.de,
	anders.roxell@linaro.org, masonccyang@mxic.com.tw,
	robh+dt@kernel.org, linux-mips@vger.kernel.org,
	hauke.mehrtens@intel.com, andriy.shevchenko@intel.com,
	qi-ming.wu@intel.com, cheol.yong.kim@intel.com
Subject: Re: [PATCH v4 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support
Date: Wed, 29 Apr 2020 17:34:46 +0200	[thread overview]
Message-ID: <20200429173446.6682dfb8@collabora.com> (raw)
In-Reply-To: <20200429104205.18780-2-vadivel.muruganx.ramuthevar@linux.intel.com>

On Wed, 29 Apr 2020 18:42:04 +0800
"Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:

> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> 
> Add YAML file for dt-bindings to support NAND Flash Controller
> on Intel's Lightning Mountain SoC.
> 
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> ---
>  .../devicetree/bindings/mtd/intel,lgm-nand.yaml    | 61 ++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> new file mode 100644
> index 000000000000..6dd899d367b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel LGM SoC NAND Controller Device Tree Bindings
> +
> +allOf:
> +  - $ref: "nand-controller.yaml"
> +
> +maintainers:
> +  - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> +
> +properties:
> +  compatible:
> +    const: intel,lgm-nand-controller
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    enum:
> +      - rx
> +      - tx
> +
> +  pinctrl-names: true
> +
> +patternProperties:
> +  "^pinctrl-[0-9]+$": true
> +
> +  "^nand@[a-f0-9]+$":
> +    type: object
> +    properties:
> +      reg:
> +        minimum: 0
> +        maximum: 7
> +
> +      nand-ecc-mode: true
> +
> +      nand-ecc-algo:
> +        const: hw
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - dmas
> +
> +additionalProperties: false
> +
> +...

Can you provide an example? I'd like to make sure the binding looks
good.

  reply	other threads:[~2020-04-29 15:34 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 10:42 [PATCH v4 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-29 10:42 ` [PATCH v4 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar,Vadivel MuruganX
2020-04-29 15:34   ` Boris Brezillon [this message]
2020-04-30  1:07     ` Ramuthevar, Vadivel MuruganX
2020-04-29 10:42 ` [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-29 11:33   ` Boris Brezillon
2020-04-29 13:29     ` Ramuthevar, Vadivel MuruganX
2020-04-29 13:32       ` Boris Brezillon
2020-04-29 14:26         ` Ramuthevar, Vadivel MuruganX
2020-04-29 14:22   ` Boris Brezillon
2020-04-29 14:33     ` Ramuthevar, Vadivel MuruganX
2020-04-29 14:48       ` Boris Brezillon
2020-04-29 15:18         ` Ramuthevar, Vadivel MuruganX
2020-04-29 15:29           ` Ramuthevar, Vadivel MuruganX
2020-04-29 15:31           ` Boris Brezillon
2020-04-30  7:50             ` Ramuthevar, Vadivel MuruganX
2020-04-30  8:21               ` Boris Brezillon
2020-04-30  8:30                 ` Ramuthevar, Vadivel MuruganX
2020-04-30  8:36                   ` Boris Brezillon
2020-04-30  9:07                     ` Ramuthevar, Vadivel MuruganX
2020-04-30 12:36                       ` Boris Brezillon
2020-04-30 13:01                         ` Boris Brezillon
2020-05-04  1:58                           ` Ramuthevar, Vadivel MuruganX
2020-05-04  2:02                           ` Ramuthevar, Vadivel MuruganX
2020-05-04  7:08                             ` Boris Brezillon
2020-05-04  7:15                               ` Ramuthevar, Vadivel MuruganX
2020-05-04  7:17                                 ` Boris Brezillon
2020-05-04  8:50                                   ` Ramuthevar, Vadivel MuruganX
2020-05-04  8:58                                     ` Boris Brezillon
2020-05-04  9:17                                       ` Ramuthevar, Vadivel MuruganX
2020-05-05  5:28                                       ` Ramuthevar, Vadivel MuruganX
2020-05-05  7:00                                         ` Boris Brezillon
2020-05-05  7:17                                           ` Ramuthevar, Vadivel MuruganX
2020-05-04  1:54                         ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429173446.6682dfb8@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=anders.roxell@linaro.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=arnd@arndb.de \
    --cc=brendanhiggins@google.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke.mehrtens@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=qi-ming.wu@intel.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).