From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02AF7C47257 for ; Sat, 2 May 2020 10:20:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D65D6216FD for ; Sat, 2 May 2020 10:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbgEBKUJ (ORCPT ); Sat, 2 May 2020 06:20:09 -0400 Received: from elvis.franken.de ([193.175.24.41]:36582 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgEBKUF (ORCPT ); Sat, 2 May 2020 06:20:05 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jUpFa-00085x-00; Sat, 02 May 2020 12:20:02 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id EE3F2C0365; Sat, 2 May 2020 12:04:22 +0200 (CEST) Date: Sat, 2 May 2020 12:04:22 +0200 From: Thomas Bogendoerfer To: Huacai Chen Cc: linux-mips@vger.kernel.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Jiaxun Yang Subject: Re: [PATCH] MIPS: perf: Remove unnecessary "fallthrough" pseudo keywords Message-ID: <20200502100422.GA3913@alpha.franken.de> References: <1588395326-5351-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588395326-5351-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, May 02, 2020 at 12:55:26PM +0800, Huacai Chen wrote: > The last branch of switch-case doesn't need a "fallthrough" pseudo > keyword, and it will cause errors when building a kernel with -Werror: > > arch/mips/kernel/perf_event_mipsxx.c: In function 'reset_counters': > include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror] > 200 | # define fallthrough __attribute__((__fallthrough__)) > | ^~~~~~~~~~~~~ > >> arch/mips/kernel/perf_event_mipsxx.c:932:3: note: in expansion of macro 'fallthrough' > 932 | fallthrough; > | ^~~~~~~~~~~ > arch/mips/kernel/perf_event_mipsxx.c: In function 'loongson3_reset_counters': > include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror] > 200 | # define fallthrough __attribute__((__fallthrough__)) > | ^~~~~~~~~~~~~ > arch/mips/kernel/perf_event_mipsxx.c:903:3: note: in expansion of macro 'fallthrough' > 903 | fallthrough; > | ^~~~~~~~~~~ > cc1: all warnings being treated as errors > > Fix it by removing unnecessary "fallthrough" pseudo keywords. > > Reported-by: kbuild test robot > Signed-off-by: Huacai Chen > --- > arch/mips/kernel/perf_event_mipsxx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_event_mipsxx.c > index a14974c..710b2c7 100644 > --- a/arch/mips/kernel/perf_event_mipsxx.c > +++ b/arch/mips/kernel/perf_event_mipsxx.c > @@ -900,7 +900,6 @@ static void loongson3_reset_counters(void *arg) > mipspmu.write_counter(0, 0); > mipsxx_pmu_write_control(0, 575<<5); > mipspmu.write_counter(0, 0); > - fallthrough; > } > } > > @@ -929,7 +928,6 @@ static void reset_counters(void *arg) > case 1: > mipsxx_pmu_write_control(0, 0); > mipspmu.write_counter(0, 0); > - fallthrough; > } > } please add breaks in both places. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]