Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] MIPS: ingenic: Replace <linux/clk-provider.h> by <linux/of_clk.h>
Date: Thu, 7 May 2020 12:00:57 +0200	[thread overview]
Message-ID: <20200507100057.GA10965@alpha.franken.de> (raw)
In-Reply-To: <CAMuHMdU=iZfBg9wkZ1JM_eLe8j-nVp0Q8761UM7p_UUEhuf1+w@mail.gmail.com>

On Thu, May 07, 2020 at 11:11:10AM +0200, Geert Uytterhoeven wrote:
> Hi Thomas,
> 
> On Thu, May 7, 2020 at 11:05 AM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> > On Wed, May 06, 2020 at 11:04:52AM +0200, Geert Uytterhoeven wrote:
> > > The JZ4740 setup code is not a clock provider, and just needs to call
> > > of_clk_init().
> > >
> > > Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> > >
> > > Fixes: f932449c11dabb4b ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  arch/mips/jz4740/setup.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Does this need to go via mips-fixes ? Or is mips-next good enough ?
> 
> The commit fixed is not yet upstream, only in next, and the fix is
> non-critical.  It could even be merged into the original commit,
> depending on your rebase policy.

no rebase on mips-next. I've applied your patch to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2020-05-07 10:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  9:04 [PATCH] MIPS: ingenic: Replace <linux/clk-provider.h> by <linux/of_clk.h> Geert Uytterhoeven
2020-05-06 10:39 ` Paul Cercueil
2020-05-07  8:40 ` Thomas Bogendoerfer
2020-05-07  9:11   ` Geert Uytterhoeven
2020-05-07 10:00     ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200507100057.GA10965@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox