* [PATCH 05/11] MIPS: constify sysrq_key_op [not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com> @ 2020-05-13 21:43 ` Emil Velikov 2020-05-14 7:49 ` Thomas Bogendoerfer 0 siblings, 1 reply; 2+ messages in thread From: Emil Velikov @ 2020-05-13 21:43 UTC (permalink / raw) To: dri-devel Cc: emil.l.velikov, Greg Kroah-Hartman, Jiri Slaby, linux-kernel, Thomas Bogendoerfer, linux-mips With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: linux-mips@vger.kernel.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better it this gets merged this via the tty tree. --- arch/mips/kernel/sysrq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/kernel/sysrq.c b/arch/mips/kernel/sysrq.c index e5a2a6ab71ac..9c1a2019113b 100644 --- a/arch/mips/kernel/sysrq.c +++ b/arch/mips/kernel/sysrq.c @@ -52,7 +52,7 @@ static void sysrq_handle_tlbdump(int key) #endif } -static struct sysrq_key_op sysrq_tlbdump_op = { +static const struct sysrq_key_op sysrq_tlbdump_op = { .handler = sysrq_handle_tlbdump, .help_msg = "show-tlbs(x)", .action_msg = "Show TLB entries", -- 2.25.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/11] MIPS: constify sysrq_key_op 2020-05-13 21:43 ` [PATCH 05/11] MIPS: constify sysrq_key_op Emil Velikov @ 2020-05-14 7:49 ` Thomas Bogendoerfer 0 siblings, 0 replies; 2+ messages in thread From: Thomas Bogendoerfer @ 2020-05-14 7:49 UTC (permalink / raw) To: Emil Velikov Cc: dri-devel, Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-mips On Wed, May 13, 2020 at 10:43:45PM +0100, Emil Velikov wrote: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: linux-mips@vger.kernel.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better it this gets merged this via the tty tree. > --- > arch/mips/kernel/sysrq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-14 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com>
2020-05-13 21:43 ` [PATCH 05/11] MIPS: constify sysrq_key_op Emil Velikov
2020-05-14 7:49 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).